Skip to content

fix: pass context_id instead of browser_id to BrowserContext.close #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
itq148 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: pass context_id instead of browser_id to BrowserContext.close #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/playwright_ex/channels/browser_context.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,12 +209,12 @@ defmodule PlaywrightEx.BrowserContext do
@schema schema
@type close_opt :: unquote(NimbleOptions.option_typespec(schema))
@spec close(PlaywrightEx.guid(), [close_opt() | PlaywrightEx.unknown_opt()]) :: {:ok, any()} | {:error, any()}
def close(browser_id, opts \\ []) do
def close(context_id, opts \\ []) do
{connection, opts} = opts |> PlaywrightEx.Channel.validate_known!(@schema) |> Keyword.pop!(:connection)
{timeout, opts} = Keyword.pop!(opts, :timeout)

connection
|> Connection.send(%{guid: browser_id, method: :close, params: Map.new(opts)}, timeout)
|> Connection.send(%{guid: context_id, method: :close, params: Map.new(opts)}, timeout)
|> ChannelResponse.unwrap(& &1)
end

Expand Down
Loading