fix: rebuild CI image when requirements.txt changes#616
Merged
Conversation
requirements-dev.txt pulls in requirements.txt via -r, but the path filter only watched requirements-dev.txt itself, so dependency additions to requirements.txt (e.g. beautifulsoup4) never triggered a rebuild of the baked CI test container.
📝 WalkthroughWalkthroughThe CI image build-and-push workflow now runs when ChangesCI image workflow
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci-image.ymlonly rebuiltghcr.io/full-bars/spc-bot/ci:latestwhenrequirements-dev.txtitself changed as a file.requirements-dev.txtpulls inrequirements.txtvia-r requirements.txt, so dependency additions torequirements.txt(e.g.beautifulsoup4in feat: /radar — NEXRAD loops with storm-scale zoom, rotation/TVS detection, and PTDS debris-signature scoring #615) never triggered a rebuild, leaving the baked test container stale.requirements.txtto the path trigger list so both files are watched.Test plan
mainand confirmBuild and Push CI Imageruns and pushes an updatedci:latesttestjob goes green afterward (or manually re-run once image is rebuilt)Summary by CodeRabbit
requirements.txtchanges.