Skip to content

chore: update fullsend shim workflow#20

Merged
ralphbean merged 1 commit into
mainfrom
fullsend/onboard
May 7, 2026
Merged

chore: update fullsend shim workflow#20
ralphbean merged 1 commit into
mainfrom
fullsend/onboard

Conversation

@fullsend-ai-fullsend
Copy link
Copy Markdown
Contributor

This PR updates the fullsend shim workflow to match the current template in the .fullsend config repo.

The shim content has drifted from the template — this brings it back in sync.

@fullsend-ai-fullsend fullsend-ai-fullsend Bot requested a review from a team as a code owner May 7, 2026 18:05
@fullsend-ai-review
Copy link
Copy Markdown

fullsend-ai-review Bot commented May 7, 2026

Review: #20

Head SHA: ad7641a
Timestamp: 2026-05-07T00:00:00Z
Outcome: approve

Summary

This PR adds pull-requests: write to the post-run-link job's permissions block, aligning it with the canonical fullsend shim template and with the permission patterns already used by other jobs in this workflow (e.g., dispatch-stop-fix). The post-run-link job comments on both issues and PRs via gh issue comment, and the additional permission ensures the GITHUB_TOKEN can write to PR resources under GitHub Actions' fine-grained permission model. The change is minimal (one line), syntactically correct, and introduces no new logic or security concerns. No findings across all six review dimensions.

Findings

No findings.

Footer

Outcome: approve
This review applies to SHA ad7641af0d54b8017a1e93442eec583145f31ef9. Any push to the PR head clears this review and requires a new evaluation.


Protected paths detected — this PR modifies files under one or more
protected paths. The review agent cannot approve PRs that touch these paths.
A human reviewer must approve this PR.

Protected files in this PR:

  • .github/workflows/fullsend.yaml
Previous run

Review: #20

Head SHA: ef9062c
Timestamp: 2026-05-07T00:00:00Z
Outcome: approve

Summary

Clean, minimal change that adds pull-requests: write to the post-run-link job's permissions block. This is necessary because the job comments on PRs (via gh issue comment) when triggered by pull_request_target events, and the fine-grained GITHUB_TOKEN may not cover PR writes with only issues: write. The permission is scoped to github.token (not the dispatch token), only affects this single job, and is consistent with the dispatch-stop-fix job which already declares both permissions for the same pattern. No findings across any of the six review dimensions.

Findings

None.

Footer

Outcome: approve
This review applies to SHA ef9062c5726ab5f462b32de7678e9a81d7e3043c. Any push to the PR head clears this review and requires a new evaluation.


Protected paths detected — this PR modifies files under one or more
protected paths. The review agent cannot approve PRs that touch these paths.
A human reviewer must approve this PR.

Protected files in this PR:

  • .github/workflows/fullsend.yaml

@ralphbean ralphbean added this pull request to the merge queue May 7, 2026
Merged via the queue into main with commit 244d484 May 7, 2026
16 of 17 checks passed
@ralphbean ralphbean deleted the fullsend/onboard branch May 7, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant