Skip to content

chore: update fullsend shim workflow#22

Closed
fullsend-ai-fullsend[bot] wants to merge 1 commit into
mainfrom
fullsend/onboard
Closed

chore: update fullsend shim workflow#22
fullsend-ai-fullsend[bot] wants to merge 1 commit into
mainfrom
fullsend/onboard

Conversation

@fullsend-ai-fullsend
Copy link
Copy Markdown
Contributor

This PR updates the fullsend shim workflow to match the current template in the .fullsend config repo.

The shim content has drifted from the template — this brings it back in sync.

@fullsend-ai-fullsend fullsend-ai-fullsend Bot requested a review from a team as a code owner May 8, 2026 11:40
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

fullsend review is working on this — view logs

@fullsend-ai-review
Copy link
Copy Markdown

Review: #22

Head SHA: 60512e2
Timestamp: 2026-05-08T11:45:00Z
Outcome: comment-only

Summary

This PR adds a new dispatch-gh-classify job that fires on newly opened issues and dispatches to gh-classify.yml in the .fullsend config repo. The change is functionally sound and follows the established security pattern of passing GitHub context through environment variables to prevent script injection — with one exception where github.repository is interpolated directly in a run: block. No critical or high findings; two style/consistency observations and one intent-alignment note.

Findings

Medium

  • [Platform security] .github/workflows/fullsend.yaml (new job, payload step run: block) — ${{ github.repository }} is interpolated directly in the run: block (--arg repo "${{ github.repository }}"), breaking the env-var-only pattern documented in the file header and used by every other job. While github.repository is GitHub-controlled and not attacker-exploitable, maintaining the pattern is important: it keeps the security posture legible for future maintainers and avoids normalizing direct ${{ }} interpolation in run: blocks where attacker-controlled fields could be introduced by copy-paste.
    Remediation: Add REPO: ${{ github.repository }} to the step's env: block and reference it as "${REPO}" in the jq command, consistent with the SOURCE_REPO pattern in the dispatch step.

Low

  • [Style/conventions] .github/workflows/fullsend.yaml (new job, dispatch step) — The dispatch step uses --field while all other dispatch jobs in this file use the -f shorthand. Functionally equivalent, but inconsistent.
    Remediation: Replace --field with -f to match the existing convention.

Info

  • [Intent alignment] The PR description frames this as "bringing the shim back in sync with the template," but the change adds new functionality: a new event trigger (opened on issues) and a new dispatch job (dispatch-gh-classify). This is a feature addition. Not a problem per se, but worth noting for accurate changelog/release-note purposes.

Footer

Outcome: comment-only
This review applies to SHA 60512e2c5947fa3754df6eb0f849e124c5bc1fb9. Any push to the PR head clears this review and requires a new evaluation.

@fullsend-ai-fullsend
Copy link
Copy Markdown
Contributor Author

Repo disabled in config.yaml (triggered by commit fa27e01b005ac3b9349b5aa92eb560380dde9639)

@fullsend-ai-fullsend fullsend-ai-fullsend Bot deleted the fullsend/onboard branch May 12, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants