feat(#461): use /fs- prefix for slash commands#742
Conversation
|
fullsend review is working on this — view logs |
Site previewPreview: https://717f1e5c-site.fullsend-ai.workers.dev Commit: |
Review: #742Head SHA: a9f0ac7 SummaryThe slash command rename from bare FindingsHigh
Medium
Info
FooterOutcome: request-changes Previous runReview: #742Head SHA: 2f6f5c7 SummaryThis PR correctly renames all slash commands from bare FindingsMedium
Info
FooterOutcome: comment-only Previous run (2)Review: #742Head SHA: 39bc6cb SummaryClean, well-scoped mechanical rename of all slash commands from bare names ( FindingsLow
Info
FooterOutcome: approve
Previous run (3)Review: #742Head SHA: 9cca3eb SummaryThis PR correctly renames all slash commands from bare FindingsMedium
FooterOutcome: comment-only Previous run (4)Review: #742Head SHA: 9ac7dcf SummaryClean, well-scoped rename from bare slash commands to FindingsMedium
Low
Info
FooterOutcome: comment-only Previous run (5)Review: #742Head SHA: 3cbe7de SummaryThis PR correctly renames all slash commands from bare FindingsMedium
Low
Info
FooterOutcome: comment-only |
|
fullsend review is working on this — view logs |
ralphbean
left a comment
ralphbean
left a comment
There was a problem hiding this comment.
Review Summary
Clean, well-scoped rename from bare slash commands to /fs- prefixed commands. The core workflow changes are correct — both shim files are in sync, fromJSON newline matching is preserved, and the sed prefix strip in fix.yml is properly updated. The glossary entry is particularly well written with good rationale for the design choices.
Two missed references to fix before merge:
1. [minor] internal/scaffold/fullsend-repo/agents/fix.md line 7
The YAML frontmatter description field still says "a /fix command" — should be /fs-fix.
2. [moderate] docs/normative/admin-install/v1/adr-0013-enrollment/SPEC.md lines 58, 86-88
This normative spec (not an ADR) still uses bare /triage in both prose and YAML code examples. Since it describes what the shim workflow should look like, it now contradicts the actual implementation. Please update /triage → /fs-triage in this file.
|
fullsend review is working on this — view logs |
There was a problem hiding this comment.
A few stale references to the old unprefixed commands remain in comments/examples:
docs/superpowers/plans/2026-05-04-retro-agent.md:229— bash comment says/retroinstead of/fs-retrointernal/scaffold/fullsend-repo/.github/workflows/fix.yml— lines 29, 130, 148, 166 still say/fixinstead of/fs-fix
(The inline comment on the spec file is the other one.)
|
fullsend review is working on this — view logs |
|
fullsend review is working on this — view logs |
Replace bare /triage, /code, /review, /fix, /retro with /fs-triage, /fs-code, /fs-review, /fs-fix, /fs-retro. Hyphen separator avoids ambiguity with prompt args (e.g. /fs-fix add error handling). Short prefix per review feedback — /fullsend was too long. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add /fs-stop-fix to bugfix workflow command table - Update retro agent spec and plan docs to use /fs- prefix Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Normative spec and fix agent description still used bare slash commands after the /fs- prefix rename. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Comments in fix.yml, retro-agent plan, and retro-agent design spec still used bare slash commands. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rh-hemartin
force-pushed
the
fix/461-fs-slash-commands
branch
from
39bc6cb to
2f6f5c7
Compare
|
fullsend review is working on this — view logs |
rh-hemartin
force-pushed
the
fix/461-fs-slash-commands
branch
from
2f6f5c7 to
1db541e
Compare
|
fullsend review is working on this — view logs |
Installer content design spec and retro-agent plan still had bare /triage, /code, /review, /retro in YAML examples. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Hector Martinez <hemartin@redhat.com>
rh-hemartin
force-pushed
the
fix/461-fs-slash-commands
branch
from
1db541e to
a9f0ac7
Compare
|
fullsend review is working on this — view logs |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/u/271249281?s=60&v=4){kind=small}
|
fullsend fix is working on this — view logs |
🔧 Fix agent — iteration 1 (bot-triggered)All 5 review findings require modifications to .github/workflows/fullsend.yaml, which is a protected CI configuration path the fix agent cannot modify. Recorded disagreements with remediation guidance for all findings. A human must: (1) rename all slash commands in fullsend.yaml to /fs- prefix, (2) restore auto-triage on issue open/edit, (3) restore the dispatch-prioritize job with /fs-prioritize, and (4) restore 'edited' in the issues.types array. Disagreed (5):
Tests: passed Decision points
Updated by fullsend fix agent |
ralphbean
left a comment
ralphbean
left a comment
There was a problem hiding this comment.
Strategic Assessment
✅ Direction: Solid. The /fs- prefix solves real collision problems with Qodo and other AI tools. Issue #461 explicitly requested this, and PR #660's /fullsend prefix was rejected as too verbose. This PR gets the balance right.
✅ Scope fit: Core dispatch infrastructure — well within project scope.
.github/workflows/fullsend.yaml (this repo's own shim) when the intended architecture is to only update internal/scaffold/ templates and upgrade this repo later via release. See inline comments.
Code-Level Findings
Two findings total:
- Important (note, defer):
.github/workflows/fullsend.yamlmodified out of scope - Important (request changes):
agents/fix.mdhas a missed/fixreference at line 64
See inline comments for details.
| on: | ||
| issues: | ||
| types: [labeled, opened, edited] | ||
| types: [labeled, opened] |
There was a problem hiding this comment.
[important] This file was modified (4 additions, 63 deletions) when the architectural pattern is to only touch internal/scaffold/ templates and upgrade this repo later via release.
Changes made:
- Removed
editedfromon.issues.types - Removed
issuesevent branch fromdispatch-triage(loses auto-triage onissues: opened) - Deleted entire
dispatch-prioritizejob (61 lines) - Updated
post-run-linkdependencies
These are behavioral changes that go beyond renaming slash commands and aren't mentioned in the PR description. Consider reverting all changes to this file and letting the upgrade happen post-release.
| reviewers, implements targeted fixes on the existing PR branch, runs tests | ||
| and linters, and commits the result. Use when the review agent requests | ||
| changes or a human issues a /fix command on a PR. | ||
| changes or a human issues a /fs-fix command on a PR. |
There was a problem hiding this comment.
[important] This PR updated /fix → /fs-fix at lines 7, 83, and 144, but missed line 64.
Line 64 currently reads:
- **Human-triggered** (`/fix [instruction]`): Follow the human's instruction.Should be:
- **Human-triggered** (`/fs-fix [instruction]`): Follow the human's instruction.This is the fix agent's system prompt describing how it interprets trigger modes — it's a live instruction served at runtime, not just documentation.
3 participants
Summary
/triage,/code,/review,/fix,/retrowith/fs-triage,/fs-code,/fs-review,/fs-fix,/fs-retro/fs-fix add error handling)/fs-prefix per review feedback on feat(#461): add /fullsend namespace prefix for slash commands #660 —/fullsendwas too long (8 chars)fromJSONnewline matching for multi-line comment bodiesSupersedes #660 with a clean, focused change.
Closes #461
Test plan
make lintpassesgo test ./internal/scaffold/...passes (pre-existingTestFileModeMatchesFilesystemfailure unrelated)/fs-reviewon a PR comment in an enrolled repo, verify dispatch triggers/reviewno longer triggers🤖 Generated with Claude Code