chore: add lint-workflow-size to cap workflow file growth

[ralphbean]

Summary

• Adds hack/lint-workflow-size, a pre-commit linter that caps workflow YAML files at 200 lines by default
• Files over the cap need an explicit # lint-workflow-size: max-lines=N override comment, making growth intentional and reviewable
• Covers both .fullsend agent workflows and the shim template
• Error messages reference ADR-0005 (forge abstraction layer) and guide toward extracting logic into scripts/

Motivated while reviewing #729, where ~85 lines of inline shell were added to review.yml. The established pattern (used by fix.yml, pre-review.sh, etc.) is to keep workflow files as thin GitHub-specific glue and put testable logic in scripts/. This linter enforces that pattern going forward.

Current overrides

File	Lines	Cap
fix.yml	305	310
prioritize-scheduler.yml	213	220
shim-workflow.yaml	469	475

All other workflow files are under the 200-line default.

Test plan

• make lint passes
• pre-commit run lint-workflow-size --all-files passes
• Verified linter catches violations (file over cap → error with actionable message)
• Verified per-file override works

🤖 Generated with Claude Code

[github-actions]

fullsend review is working on this — view logs

[github-actions]

Site preview

Preview: https://c5689582-site.fullsend-ai.workers.dev

Commit: 5dec679e97b3cc8f2b4f33d2a7bbc2172b70e7ec

[github-actions]

fullsend review is working on this — view logs

[fullsend-ai-review]

Review: #791

Head SHA: 5dec679
Timestamp: 2026-05-11T00:00:00Z
Outcome: approve

Summary

Clean, well-scoped addition of a pre-commit linter that caps workflow YAML file growth. The bash script is correct — proper error handling (set -euo pipefail), safe glob iteration, and a reviewable per-file override mechanism. The pre-commit hook configuration follows the established hack/lint-* pattern. All override caps are verified to exceed their respective file sizes on the PR branch. No security, injection, or style concerns.

Findings

Info

• [stale-docs] PR body table — The PR description claims shim-workflow.yaml is 469 lines (cap 475), but on current main it is 528 lines and on this branch it is 529 lines (cap 535). The code is correct; only the PR body table is stale. No action required.

Footer

Outcome: approve
This review applies to SHA 5dec679e97b3cc8f2b4f33d2a7bbc2172b70e7ec. Any push to the PR head clears this review and requires a new evaluation.

---

Protected paths detected — this PR modifies files under one or more
protected paths. The review agent cannot approve PRs that touch these paths.
A human reviewer must approve this PR.

Protected files in this PR:

• .pre-commit-config.yaml

Previous run

Review: #791

Head SHA: 9317f6d
Timestamp: 2026-05-11T00:00:00Z
Outcome: approve

Summary

Clean, well-scoped addition of a workflow file size linter that enforces an existing architectural pattern (workflow files as thin GitHub-specific glue, logic in scripts/). The script is correctly implemented with proper error handling (set -euo pipefail, guarded grep), follows established hack/ linter conventions, and the pre-commit integration is properly scoped. No correctness, security, or injection concerns found.

Findings

Info

• [correctness] PR description — The "Current overrides" table in the PR body claims shim-workflow.yaml is 469 lines with cap 475, but the actual file is 528 lines and the code override is max-lines=535. The code is correct; only the description table is stale. No action required.

Footer

Outcome: approve
This review applies to SHA 9317f6daa4bdead87e60520b970c07f31ea98ecc. Any push to the PR head clears this review and requires a new evaluation.

---

Protected paths detected — this PR modifies files under one or more
protected paths. The review agent cannot approve PRs that touch these paths.
A human reviewer must approve this PR.

Protected files in this PR:

• .pre-commit-config.yaml

Previous run (2)

Review: #791

Head SHA: 0f11b9c
Timestamp: 2026-05-11T00:00:00Z
Outcome: request-changes

Summary

The linter script is well-structured and the approach of capping workflow file size is sound. However, the PR branch is stale relative to main: PR #785 rewrote shim-workflow.yaml to 528 lines, but this PR sets the override cap at 475. The linter will fail immediately after merge. The override must be updated to accommodate the current file size. Additionally, the script uses grep -oP (PCRE), which is not available on macOS BSD grep — a portability concern for pre-commit hooks.

Findings

High

• [Correctness] internal/scaffold/fullsend-repo/templates/shim-workflow.yaml — Stale override cap will break the build. The file is 528 lines on current main (after PR fix: restore automatic triage on issue open/edit #785 merged), but the override is set to max-lines=475. After merge (529 lines with the added comment), the linter will immediately fail. The PR was branched before fix: restore automatic triage on issue open/edit #785 landed.
  Remediation: Rebase onto current main and update the override to at least max-lines=535 (or whatever the post-rebase line count requires, with reasonable headroom).

Medium

• [Correctness] hack/lint-workflow-size:42 — grep -oP uses Perl-Compatible Regular Expressions (PCRE), which is not supported by macOS BSD grep. While the primary dev environment appears to be Linux-based (devaipod), pre-commit hooks run on any developer machine. This will produce a silent failure (|| true swallows the error) and fall back to the default cap, masking intentional overrides on macOS.
  Remediation: Replace with a POSIX-compatible alternative, e.g.: grep -o 'max-lines=[0-9]*' "${file}" | grep -o '[0-9]*' | tail -1

Footer

Outcome: request-changes
This review applies to SHA 0f11b9c64feffab19c0fe6026d3a3bdd09430a54. Any push to the PR head clears this review and requires a new evaluation.

[fullsend-ai-review]

See the review comment for full details.

[github-actions]

fullsend fix is working on this — view logs

[github-actions]

fullsend review is working on this — view logs

[github-actions]

fullsend review is working on this — view logs