Skip to content

Spec: web UI icon fonts instead of inline SVG (#818)#858

Closed
ifireball wants to merge 1 commit into
fullsend-ai:mainfrom
ifireball:agent/818-spec-web-icon-fonts
Closed

Spec: web UI icon fonts instead of inline SVG (#818)#858
ifireball wants to merge 1 commit into
fullsend-ai:mainfrom
ifireball:agent/818-spec-web-icon-fonts

Conversation

@ifireball
Copy link
Copy Markdown
Contributor

Summary

Headless spec-start pass for fullsend-ai/fullsend#818: migrate docs/admin UI chrome icons from inline SVG to an icon font for easier styling and better caching on the wire.

Topic directory

docs/plans/2026-05-13-web-icon-fonts/spec.md, qna.md

Recommended approach (short)

Self-host Material Symbols Outlined (variable font) via the Vite pipeline, shared CSS/conventions across web/docs and web/admin, replace inline <svg> in the shell components called out in the issue. Treat Mermaid diagram SVG as out of scope; decide GitHub logo via brand policy (font glyph vs one documented SVG exception).

Top open questions

  1. Is Material’s visual language acceptable, or should we prefer Font Awesome / a custom subset font?
  2. GitHub mark: approved font glyph vs retained inline SVG under brand rules?
  3. Shared web/shared CSS vs duplicated per-app imports?

What to review

  • docs/plans/2026-05-13-web-icon-fonts/spec.md — options, recommendation, rollout, testing
  • docs/plans/2026-05-13-web-icon-fonts/qna.md — assumptions and scope boundary (Mermaid)

Refs #818

Made with Cursor

Adds headless spec and Q&A for migrating inline SVG chrome icons
to a self-hosted icon font, scoped to docs/admin Svelte shells.

Refs fullsend-ai#818

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions
Copy link
Copy Markdown

fullsend review is working on this — view logs

@github-actions
Copy link
Copy Markdown

Site preview

Preview: https://9839fe8c-site.fullsend-ai.workers.dev

Commit: d7fe0abfeffa108c512fcdb49252c100fca76efe

@fullsend-ai-review
Copy link
Copy Markdown

Review: #858

Head SHA: d7fe0ab
Timestamp: 2026-05-13T00:00:00Z
Outcome: approve

Summary

Clean spec-start PR that adds two planning documents (spec.md and qna.md) for migrating web UI chrome icons from inline SVG to an icon font, as requested in #818. The spec presents three architectural options with trade-offs and a clear recommendation (Material Symbols Outlined, self-hosted), which aligns with the repo's convention of exploring options rather than prescribing solutions. No code changes — documentation only. All six review dimensions pass with no findings.

Findings

No findings.

Footer

Outcome: approve
This review applies to SHA d7fe0abfeffa108c512fcdb49252c100fca76efe. Any push to the PR head clears this review and requires a new evaluation.

@ifireball
Copy link
Copy Markdown
Contributor Author

Closing per maintainer request: cleanup (withdraw draft spec PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant