Skip to content

align image names with rhub#61

Merged
j-i-l merged 13 commits intomainfrom
upgraded-container-targets
Apr 15, 2026
Merged

align image names with rhub#61
j-i-l merged 13 commits intomainfrom
upgraded-container-targets

Conversation

@j-i-l
Copy link
Copy Markdown
Member

@j-i-l j-i-l commented Apr 13, 2026

We are using a deprecated naming scheme and aligning it somewhat inconsistently to the actual r-hub containers:

# Map debian combinations
if [[ "$TARGET_OS" == "debian" ]]; then
if [[ "$COMPILER" == "clang" && "$R_VERSION" == "devel" ]]; then
RHUB_IMAGE="ubuntu-clang"
elif [[ "$COMPILER" == "gcc" && "$R_VERSION" == "devel" ]]; then
RHUB_IMAGE="ubuntu-gcc12"
elif [[ "$R_VERSION" == "release" ]]; then
RHUB_IMAGE="ubuntu-release"
elif [[ "$R_VERSION" == "patched" ]]; then
RHUB_IMAGE="ubuntu-next"
fi
# Map fedora combinations
elif [[ "$TARGET_OS" == "fedora" ]]; then
# Note: R-hub doesn't have direct fedora equivalents for primary CRAN containers
# Map to closest Ubuntu equivalents or specific Fedora containers
if [[ "$COMPILER" == "gcc" && "$R_VERSION" == "devel" ]]; then
RHUB_IMAGE="gcc15" # Use Fedora-based gcc15 container
elif [[ "$COMPILER" == "clang" && "$R_VERSION" == "devel" ]]; then
RHUB_IMAGE="gcc15" # No Fedora clang equivalent, use Fedora gcc15
echo "Warning: No direct Fedora clang equivalent on r-hub, using gcc15"
fi
# Map valgrind
elif [[ "$TARGET_OS" == "valgrind" ]]; then
RHUB_IMAGE="valgrind"
fi

By aligning our container naming with the r-hub sources the setup should become clearer.

@j-i-l j-i-l added the build::check Label to trigger a bild process of the docker containers label Apr 13, 2026
@github-actions github-actions bot added build::failed Build process failed and removed build::check Label to trigger a bild process of the docker containers labels Apr 13, 2026
@j-i-l j-i-l added build::check Label to trigger a bild process of the docker containers and removed build::failed Build process failed labels Apr 13, 2026
@github-actions github-actions bot added build::failed Build process failed and removed build::check Label to trigger a bild process of the docker containers labels Apr 13, 2026
@j-i-l j-i-l added build::check Label to trigger a bild process of the docker containers and removed build::failed Build process failed build::check Label to trigger a bild process of the docker containers labels Apr 13, 2026
@j-i-l j-i-l added build::check Label to trigger a bild process of the docker containers and removed build::check Label to trigger a bild process of the docker containers labels Apr 13, 2026
@github-actions github-actions bot added build::failed Build process failed and removed build::check Label to trigger a bild process of the docker containers labels Apr 13, 2026
@j-i-l
Copy link
Copy Markdown
Member Author

j-i-l commented Apr 13, 2026

it seems fs needs libuvl, tries (and fails) to build it locally. We install libuvl directly. If cmake is available then fs should succeed.

@j-i-l j-i-l added build::check Label to trigger a bild process of the docker containers and removed build::failed Build process failed labels Apr 13, 2026
@github-actions github-actions bot added build::failed Build process failed and removed build::check Label to trigger a bild process of the docker containers labels Apr 13, 2026
@j-i-l
Copy link
Copy Markdown
Member Author

j-i-l commented Apr 13, 2026

there seems to be an issue with the installation of fs. it seems to always attempt to build libuvl, even if it is already available on the system. This looks like a bug...

for us we can simply promote the cmake install and 'fs' build.

@j-i-l j-i-l added build::check Label to trigger a bild process of the docker containers and removed build::failed Build process failed labels Apr 13, 2026
@github-actions github-actions bot added the build::failed Build process failed label Apr 14, 2026
@j-i-l j-i-l added build::check Label to trigger a bild process of the docker containers and removed build::failed Build process failed labels Apr 14, 2026
@github-actions github-actions bot added build::failed Build process failed and removed build::check Label to trigger a bild process of the docker containers labels Apr 14, 2026
@j-i-l j-i-l added build::check Label to trigger a bild process of the docker containers and removed build::failed Build process failed labels Apr 14, 2026
@github-actions github-actions bot added build::failed Build process failed and removed build::check Label to trigger a bild process of the docker containers labels Apr 14, 2026
@j-i-l
Copy link
Copy Markdown
Member Author

j-i-l commented Apr 14, 2026

the fedora-gcc-devel container is failing because of rlang:

https://github.com/furrer-lab/r-containers/actions/runs/24400424277/job/71269219709?pr=61#step:6:7159

this seems to be an inconsistency between fedora and the r development version, nothing on our table.
For now we simply allow this container to fail silently.

@j-i-l j-i-l added build::check Label to trigger a bild process of the docker containers and removed build::failed Build process failed labels Apr 14, 2026
@github-actions github-actions bot added build::passed Build process finished sucessfully and removed build::check Label to trigger a bild process of the docker containers labels Apr 14, 2026
@j-i-l j-i-l added build::check Label to trigger a bild process of the docker containers and removed build::passed Build process finished sucessfully labels Apr 14, 2026
@github-actions github-actions bot added build::passed Build process finished sucessfully and removed build::check Label to trigger a bild process of the docker containers labels Apr 14, 2026
@j-i-l j-i-l merged commit 1cdd235 into main Apr 15, 2026
15 checks passed
@j-i-l j-i-l added build::check Label to trigger a bild process of the docker containers build::passed Build process finished sucessfully and removed build::passed Build process finished sucessfully build::check Label to trigger a bild process of the docker containers labels Apr 15, 2026
@j-i-l j-i-l deleted the upgraded-container-targets branch April 15, 2026 16:25
This was referenced Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build::passed Build process finished sucessfully

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant