Revert "Fix iterator moving backwards and created unit test for the J…#63
Merged
Merged
Conversation
davsclaus
added a commit
that referenced
this pull request
May 21, 2015
Revert "Fix iterator moving backwards and created unit test for the J…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #52
leveldb API says:
// Position at the last key in the source. The iterator is
// Valid() after this call iff the source is not empty.
virtual void SeekToLast() = 0;
This commit put the iterator at a fake position after the last key, which is not correct. The moving back
is thus changed, and assertion failure happens.
API behavior cannot be changed this way.
DBTest.java is failing and thus build fails.
Every commit should at least make build clear.
So I am filing this PR to revert it.