[codex] Fix create market static export#81
Draft
krandder wants to merge 1 commit into
Draft
Conversation
✅ Deploy Preview for futarchy ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
/markets/newwith a static import ofCreateMarketFlow.next exportinclude the create-market UI in the generated page bundle instead of serving an empty shell that depends on async chunks that are currently 404ing in production.Why
After PR #77 was merged,
https://futarchy.fi/markets/newreturned 200 but the static HTML was an empty Next shell and its dynamic chunks returned 404. The page route existed, but the Create Market UI was not actually usable live.Validation
npx eslint src/pages/markets/new/index.jsx src/components/futarchyFi/createMarket/CreateMarketFlow.jsx src/features/marketCreation/marketCreationWorkflow.js auto-qa/tests/market-creation-workflow.test.mjsnode --test auto-qa/tests/market-creation-workflow.test.mjs(8 tests)npm run buildout/markets/new.htmlandout/_next/static/chunks/pages/markets/new-*.jscontainCreate Market,Contract Actions,FutarchyLiquidityManagerFactory, andSnapshotLinkRegistry.Current production before this fix
https://futarchy.fi/markets/newreturns 200 but serves an empty shell.https://futarchy.fi/_next/static/chunks/2872-132f9eb21ff3b203.jsreturns 404.https://futarchy.fi/_next/static/chunks/4986-71e8163c575a3e1a.jsreturns 404.