Draft
Conversation
I was getting lots of rate limit messages while trying to merge a bunch
of stuff on my account.
I was getting responses such as:
x-ratelimit: {"name":"AUTHED_API_POST_LIMIT","period":1,"limit":1,
"remaining":0,"until":"2024-03-12T15:10:32Z"}
retry-after: 1
I added this retry logic which may be useful, but ultimately it
looks like the rate-limit tha tis set by the CLI should probably be used,
but is not currently used in the executor for the merge?
Author
|
I'm happy to rework this to try and make use of the Should I try and just use |
This seems to basiucally fix the issue, and no longer require the retry code that I wrote in the previous patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting lots of rate limit messages while trying to merge a bunch
of stuff on my account.
I was getting responses such as:
I added this retry logic which may be useful, but ultimately it
looks like the rate-limit that is set by the CLI should probably be used,
but is not currently used in the executor for the merge?