Skip to content
This repository was archived by the owner on May 7, 2020. It is now read-only.

[WIP] Cortical layers#4

Closed
lamblin wants to merge 2 commits into
fvisin:masterfrom
lamblin:cortical_layers
Closed

[WIP] Cortical layers#4
lamblin wants to merge 2 commits into
fvisin:masterfrom
lamblin:cortical_layers

Conversation

@lamblin

@lamblin lamblin commented May 26, 2017

Copy link
Copy Markdown
Contributor

This is @adri-romsor's loader for a 1D dataset for segmentation of cortical layers.
I'm wondering if it would make sense to include it here, and what would be needed for inclusion.

lamblin added 2 commits May 26, 2017 19:07
- import new dataset for cortical layers
- use __all__ to avoid #noqa
- make sure we call "git rev-parse HEAD" in the right directory
@lamblin
lamblin force-pushed the cortical_layers branch from ce339fb to 5a3e5dd Compare May 26, 2017 23:10
@lamblin

lamblin commented May 26, 2017

Copy link
Copy Markdown
Contributor Author

Actually, most of the changes to __init__.py should probably go in a separate PR.

@fvisin

fvisin commented May 30, 2017

Copy link
Copy Markdown
Owner

Thanks for the PR. I begun looking into it (sorry in advance, I don't have much time in the next weeks but I'll try my best to do it in a reasonable amount of time) and it looks like there is a lot of duplicated code.

What are the main differences introduced by parallel_loader_1D? Do you think it would be possible to modify parallel_loader.py directly, e.g., by checking self.data_shape to detect the 1D case? If not, is there a way to reuse the code from parallel_loader.py, e.g., by splitting the existing methods in more fine-grained submethods that can be overridden by the 1D class?

Actually, most of the changes to __init__.py should probably go in a separate PR.

It should indeed, but we can be not too formal on that, for this once. ;)
Thanks for those changes BTW, a nice improvement over what I wrote!

@lamblin

lamblin commented May 31, 2017

Copy link
Copy Markdown
Contributor Author

Replaced by #5.

@lamblin

lamblin commented May 31, 2017

Copy link
Copy Markdown
Contributor Author

And the changes in __init__.py are in #6.

@lamblin lamblin closed this May 31, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants