refactor: migrate interactive prompts from survey to huh - #955
Closed
nf-matt wants to merge 18 commits into
Closed
Conversation
Adds testable.Ask for multi-question forms and replaces ten direct survey.AskOne / survey.Ask callers that bypassed the shim.
Adds the Prompter interface and a testable.Confirm function as the entry point for migrated callers. The huh implementation writes to os.Stderr (granted's stdout is shell-evaluated) and binds ESC alongside Ctrl+C to the form's Quit action, since huh v2 binds Ctrl+C only.
Uses generic huh.Select[string] and inherits the ESC-cancel keybinding from the form keymap.
Replaces twelve survey.Select sites that used only Message and Options. Each migration drops the survey.WithStdio boilerplate since the Prompter handles stderr internally. One adjacent Confirm in browser/detect.go is migrated as well because it shared the now-removed withStdio variable.
Replaces twelve survey.Input sites. The settings/set.go Int case keeps
the existing string-through-interface{} path (no behaviour change).
Migrates the secret-access-key Password prompt and six Confirm prompts (alias install, default-browser-firefox, uninstall config, credentials removal, settings/set Bool case, registry setup). Drops the var prompt survey.Prompt declaration in settings/set.go since none of the cases reference it anymore.
Adds InputWithValidator and SelectWithValidator to the Prompter interface, plus a Required helper for the common non-empty case.
- credentials.go AddCredentialsCommand: survey.MinLength(1) becomes testable.Required (equivalent semantics). - credentials.go ImportCredentialsCommand: custom validator now receives the selected string directly instead of a core.OptionAnswer. - config_yaml.go required-keys prompt: the survey.Ask multi-question form only ever held a single Question (var questions was declared inside the loop). Collapses to InputWithValidator + SaveKey, dropping the ansmap intermediary. The now-unused SaveKeys function is removed and SaveKey's stale doc comment is updated.
huh.Select's built-in filter is literal substring only with no public matcher hook; bubbles/list exposes a Filter field that takes a func, so the implementation drops one layer down to build the picker directly. The non-modal key handler mirrors survey's UX: typing appends to the filter, arrows navigate, Enter selects, Esc clears the filter or quits. The default bubbles/list keymap is replaced with bindings that match what's actually wired up.
QueryProfiles drops the survey.Select call and the associated SelectQuestionTemplate global-mutation hack used to render the Profile/Description column header. The header is now pre-printed via fmt.Fprintln before launching the picker, which works because bubbles/list runs inline. filterMultiToken is restored with a simpler (term, opt) signature.
Help-text variants backed by huh's Description() on the underlying field. Each shares a single private helper with its plain counterpart.
- browser/detect.go SSOBrowser: Confirm with Help -> ConfirmWithHelp - settings/requesturl/set.go: Input with Help -> InputWithHelp
Removes testable.AskOne and testable.Ask along with the survey and survey/core imports from pkg/testable. go mod tidy drops AlecAivazis/survey/v2 from go.mod entirely. The library was archived by its author in 2024.
Adds grantedTheme (based on huh.ThemeCharm) and styling helpers for the bubbles/list-based filter picker. Replaces the fuchsia/indigo accents with ANSI cyan and green, removes the outer left-border around focused fields, and switches every colour to ANSI 16 indices so the prompts pick up the user's terminal palette instead of Charm's hex codes. The filter picker's focused row indicator becomes a > cursor in cyan with green option text, matching huh.Select's SelectSelector + SelectedOption convention. Status bar stays visible to show the active filter text.
nf-matt
force-pushed
the
huh-ui-migration
branch
from
July 14, 2026 15:01
60a23fc to
3d91fd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the migration proposed in #945.
AlecAivazis/surveyis archived (last release June 2023, 74 open issues) and its API blocks features like ESC-to-cancel. This branch replaces it withhuh(actively maintained, generically-typedSelect, first-class theming, built-in ESC-cancel) behind the existingpkg/testableshim, and drops thesurveydependency.Why one branch instead of the per-package PRs from the RFC: I didn't hear back on #945, so I've consolidated the work here. The commits still follow the RFC's incremental plan — each is behavior-equivalent, self-contained, and independently revertible, so this can be reviewed commit-by-commit.
Commit progression (18 commits):
huhv2; introduce aPrompterinterface with a huh-backedConfirm; migratecfaws/env.go.Select/Input/Passwordmethods and migrate their callers, package by package.Input/Selectand migrate validator-using callers.SelectWithFilter(bubbles/list) and migrate theassumeprofile picker — removing theSelectQuestionTemplatemonkey-patch andprofileNameMapworkaround called out in the RFC.ConfirmWithHelp/InputWithHelpand migrate Help-using callers.surveydependency.Verification:
go build ./...clean;go test ./...passes (10 packagesok, no failures).