Open
Conversation
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Vector typedef was duplicated
Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Steffen Vogel <post@steffenvogel.de>
…uilds Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Steffen Vogel <post@steffenvogel.de>
To allow C plugins to include MNASolverDynInterface, `extern "C"` needs to be wrapped in a preprocessor condition for C++ only. Signed-off-by: Felix Wege <fwege@eonerc.rwth-aachen.de>
Signed-off-by: Felix Wege <fwege@eonerc.rwth-aachen.de>
Signed-off-by: Felix Wege <fwege@eonerc.rwth-aachen.de>
MNASolverPlugin examples were not compilable on current `master`. This PR fixes: 1. `MNASolverDynInterface.h` not includable in C plugins due to C++ specific usage of `extern "C"` 2. Include paths in Makefiles of example and magma plugin 3. Library name of example plugin
Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Remove trailing whitespaces Harmonize file endings to single empty line Signed-off-by: Steffen Vogel <post@steffenvogel.de>
- Remove trailing whitespaces. - Harmonize file endings to single empty line.
Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
At the moment, checking for secret existence (in old ways) in PRs from forks leads to not running the sonar checks for them.
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Some of the commands are being passed as input, this prevents them to reach the shell
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Avoids passing commands as inputs in script
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Extra updates about installation methods, how to contribute and how to try DPsim
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
This PR updates the changes not yet included, to document the release v1.2.0
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Updated package versions in python and cpp. Updated sonar properties and ChangeLog. Resolves sogno-platform#452
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
…atform#459) Because the TestPyPI and PyPI are part of the same job, there is a mixup with the reusing of attestations. Separated into two jobs so to avoid the workspace to be shared.
+ added declaration for "static void calculateStateSpaceTrapezoidalMatrices(...)" which transforms state space matrices A and B and omits C and D to "MathUtils.h" + added corresponding definition of "static void calculateStateSpaceTrapezoidalMatrices(...)" to "MathUtils.cpp" Signed-off-by: Marvin Tollnitsch <marvin.tollnitsch@rwth-aachen.de>
+ added "EMT::Ph1::SSN::Full_Serial_RLC" class with "EMT_Ph1_SSN_Full_Serial_RLC.h" and "EMT_Ph1_SSN_Full_Serial_RLC.cpp"
+ added "EMT::Ph1::SSNTypeI2T" class with "EMT_Ph1_SSNTypeI2T.h" and "EMT_Ph1_SSNTypeI2T.cpp" for a generalized model of an arbitrary two terminal I-type SSN component
+ added "EMT::Ph1::SSNTypeV2T" class with "EMT_Ph1_SSNTypeV2T.h" and "EMT_Ph1_SSNTypeV2T.cpp" for a generalized model of an arbitrary two terminal V-type SSN component
+ added above headers ("EMT_Ph1_SSN_Full_Serial_RLC.h", "EMT_Ph1_SSNTypeI2T.h", "EMT_Ph1_SSNTypeV2T.h") to "Components.h" to include them into the project
+ added above cpp files ("EMT_Ph1_SSN_Full_Serial_RLC.cpp", "EMT_Ph1_SSNTypeI2T.cpp", "EMT_Ph1_SSNTypeV2T.cpp") to the "CMakeLists.txt" for component models
Signed-off-by: Marvin Tollnitsch <marvin.tollnitsch@rwth-aachen.de>
Signed-off-by: Marvin Tollnitsch <marvin.tollnitsch@rwth-aachen.de>
+ added "EMT_Ph1_General2TerminalSSN.cpp" and corresponding notebook "EMT_Ph1_generalizedSSN.ipynb" + added "EMT_Ph1_General2TerminalSSN.cpp" to "examples/cxx/CMakeLists.txt" as a circuit source + added "EMT_generalizedSSN_RLC_dpsimpy.ipynb" to test generalized SSN RLC implementation in a circuit via pybind Signed-off-by: Marvin Tollnitsch <marvin.tollnitsch@rwth-aachen.de>
Signed-off-by: Georgii Tishenin <georgii.tishenin@eonerc.rwth-aachen.de>
- all switches have hasComponentChanged functionality - in matrix recomputation case in mna solver, switch components are only restamped once with VarCompInterface Signed-off-by: cwirtz <christoph.wirtz@fgh-ma.de>
…#419) The PR does the following adaptations to unify the behavior of variable components: - changes Switch components to implement the MNAVariableCompInterface - adds hasParameterChanged() implementation - adds a new member variable for Switch: protected: Bool isClosedPrev to store the last state of the switch and compare if there are changes This is a different way to do the computation, may imply breaking changes for some implementations that depend too strictly on the old behavior of switches. Resolves sogno-platform#415
- DP_Ph3_PiLine - EMT_Ph1_PiLine Extended Examples DP_PiLine.cpp and EMT_PiLine.cpp to test new Components. To provide Diakoptics equivalent to the DP 1Ph example, minor extension of diakoptics solver to provide 3ph capability was necessary. - tearing Matrix needs to differ between 1ph and 3ph case - added mnaTearing capabilities where missing, equivalent to 1ph DP implementation Signed-off-by: cwirtz <christoph.wirtz@fgh-ma.de>
…-platform#436) This PR adds missing PiLine Models: - DP_Ph3_PiLine - EMT_Ph1_PiLine Extends Examples DP_PiLine.cpp and EMT_PiLine.cpp to test new Components. To provide Diakoptics equivalent to the DP 1Ph example, minor extension of diakoptics solver to provide 3ph capability was necessary. - tearing Matrix needs to differ between 1ph and 3ph case - added mnaTearing capabilities by implementing the interface where missing, equivalent to 1ph DP implementation This is loosely connected to issue sogno-platform#431 (adds 3ph Diakoptics functionality).
Signed-off-by: Georgii Tishenin <georgii.tishenin@eonerc.rwth-aachen.de>
This PR removes outdated info from [Roadmap in Documentation](https://dpsim.fein-aachen.org/docs/roadmap/).
Signed-off-by: Charan Dande <charan.dande@eonerc.rwth-aachen.de>
Signed-off-by: Felix Wege <fwege@eonerc.rwth-aachen.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.