Require inner join on offer if sorting by offer#12
Open
iworkinprogress wants to merge 4 commits intofxhash:masterfrom
Open
Require inner join on offer if sorting by offer#12iworkinprogress wants to merge 4 commits intofxhash:masterfrom
iworkinprogress wants to merge 4 commits intofxhash:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes a change to the API that will automatically join the offer table when trying to sort
ObjktbyofferPriceorofferCreatedAt.If the offer table isn't included then trying to use either of those sort options fails and throws a cryptic. It was not immediately clear that you needed to include a filter along with these sort options.
This change should allow this to work (which fails in production):
Note: