Skip to content

feat: build docker images for tag versions - #603

Open
thejch wants to merge 1 commit into
g0ldyy:mainfrom
thejch:fix/docker-build-tags
Open

feat: build docker images for tag versions#603
thejch wants to merge 1 commit into
g0ldyy:mainfrom
thejch:fix/docker-build-tags

Conversation

@thejch

@thejch thejch commented Jul 14, 2026

Copy link
Copy Markdown

The CI is somehow missing the build for release tags. This PR adds it, so that these stable version releases can be used in a containerized environment, instead of one having to follow latest or manually pinning the sha.

Summary by CodeRabbit

  • New Features

    • Docker images are now automatically built and published when version tags are pushed.
    • Published images receive full-version, major-version, and minor-version tags.
  • Bug Fixes

    • Improved workflow routing to prevent tagged releases from being processed as regular branch builds.

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The Docker workflow now triggers on v* tags, excludes tags from branch builds, and adds a dedicated tag-publishing job that pushes semver-based Docker tags to Docker Hub.

Changes

Docker image publishing

Layer / File(s) Summary
Tag triggers and branch routing
.github/workflows/docker-build-push.yml
The workflow accepts v* tag pushes, while the branch build job excludes tag refs.
Version tag publishing
.github/workflows/docker-build-push.yml
A tag-specific job invokes the shared Docker workflow, enables Docker Hub pushes, applies full-version and major/minor semver tags, and passes COMET_BRANCH.

Sequence Diagram(s)

sequenceDiagram
  participant GitHubActions
  participant DockerBuildCommon as docker-build-common.yml
  participant DockerHub
  GitHubActions->>DockerBuildCommon: Invoke tag build for v* refs
  DockerBuildCommon->>DockerHub: Push full-version and major.minor image tags
Loading

Suggested reviewers: g0ldyy, ashukozioko

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding Docker image builds for tagged release versions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/docker-build-push.yml (1)

30-30: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Simplify the branch condition.

You can simplify this condition by leveraging github.ref_type and github.ref_name to make the intent clearer.

♻️ Proposed refactor
-    if: github.ref != 'refs/heads/main' && github.ref != 'refs/heads/development' && github.ref_type != 'tag'
+    if: github.ref_type == 'branch' && github.ref_name != 'main' && github.ref_name != 'development'
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/docker-build-push.yml at line 30, Update the workflow job
condition to use github.ref_type and github.ref_name, allowing pushes to the
main and development branches or any tag while excluding other refs. Replace the
current combined github.ref comparisons with the simpler equivalent expression.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.github/workflows/docker-build-push.yml:
- Line 30: Update the workflow job condition to use github.ref_type and
github.ref_name, allowing pushes to the main and development branches or any tag
while excluding other refs. Replace the current combined github.ref comparisons
with the simpler equivalent expression.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ddf13f61-b475-431b-a08c-51863caff24e

📥 Commits

Reviewing files that changed from the base of the PR and between 060a8a2 and 65ecd4f.

📒 Files selected for processing (1)
  • .github/workflows/docker-build-push.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant