feat: build docker images for tag versions - #603
Conversation
WalkthroughThe Docker workflow now triggers on ChangesDocker image publishing
Sequence Diagram(s)sequenceDiagram
participant GitHubActions
participant DockerBuildCommon as docker-build-common.yml
participant DockerHub
GitHubActions->>DockerBuildCommon: Invoke tag build for v* refs
DockerBuildCommon->>DockerHub: Push full-version and major.minor image tags
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/docker-build-push.yml (1)
30-30: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueSimplify the branch condition.
You can simplify this condition by leveraging
github.ref_typeandgithub.ref_nameto make the intent clearer.♻️ Proposed refactor
- if: github.ref != 'refs/heads/main' && github.ref != 'refs/heads/development' && github.ref_type != 'tag' + if: github.ref_type == 'branch' && github.ref_name != 'main' && github.ref_name != 'development'🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/docker-build-push.yml at line 30, Update the workflow job condition to use github.ref_type and github.ref_name, allowing pushes to the main and development branches or any tag while excluding other refs. Replace the current combined github.ref comparisons with the simpler equivalent expression.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/docker-build-push.yml:
- Line 30: Update the workflow job condition to use github.ref_type and
github.ref_name, allowing pushes to the main and development branches or any tag
while excluding other refs. Replace the current combined github.ref comparisons
with the simpler equivalent expression.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ddf13f61-b475-431b-a08c-51863caff24e
📒 Files selected for processing (1)
.github/workflows/docker-build-push.yml
The CI is somehow missing the build for release tags. This PR adds it, so that these stable version releases can be used in a containerized environment, instead of one having to follow latest or manually pinning the sha.
Summary by CodeRabbit
New Features
Bug Fixes