Refactored Merge-DatumArray for performance optimization#175
Open
DoLearnWhileAlive wants to merge 6 commits into
Open
Refactored Merge-DatumArray for performance optimization#175DoLearnWhileAlive wants to merge 6 commits into
Merge-DatumArray for performance optimization#175DoLearnWhileAlive wants to merge 6 commits into
Conversation
Contributor
Author
|
PR is now ready for review. |
DoLearnWhileAlive
force-pushed
the
refactormergedatumarray
branch
from
abe0d71 to
ed73019
Compare
- Replaced O(n²) nested loop comparisons using `Compare-Hashtable` with O(n+m) hash-based indexing - Pre-computed knockout reference items to avoid repeated checks during merge - Changed output type from `[System.Collections.ArrayList]` to `[System.Collections.Generic.List[object]]` - Added private function `Get-DatumTupleKeyValueString` for consistent composite key generation - Added private function `Test-DatumKnockout` for efficient knockout matching - Removed private function `Compare-Hashtable.ps1` (no longer needed)
to ensure also node specific Datum handler values from lower layers are merged correctly.
since bug is fixed and tests are enabled
otherwise follow-up nodes merge the same tuple key values as the first node.
DoLearnWhileAlive
force-pushed
the
refactormergedatumarray
branch
from
ed73019 to
3d9cfc5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compare-Hashtablewith O(n+m) hash-based indexing[System.Collections.ArrayList]to[System.Collections.Generic.List[object]]Get-DatumTupleKeyValueStringfor consistent composite key generationTest-DatumKnockoutfor efficient knockout matchingCompare-Hashtable.ps1(no longer needed)