CSS Refactor#32
Conversation
Imran-imtiaz48
left a comment
Imran-imtiaz48
left a comment
There was a problem hiding this comment.
The CSS is clean, structured, and easy to maintain. I like the consistent sectioning and the way the styles are grouped logically with clear comments. The use of CSS variables such as var(--error-color) and var(--surface-2) keeps the design system scalable and theme-friendly. The layout decisions are practical, especially the responsive handling in .grant-form with flex-wrap, and the horizontal overflow support for the users table. Sticky table headers improve usability for long datasets, and the expandable .rooms-list approach keeps the UI uncluttered by default. Naming conventions are also consistent and readable throughout the file. One small improvement would be to consider adding transition effects for interactive elements like .rooms-toggle and .rooms-list.expanded to make the UI feel smoother. You could also add focus states for accessibility on buttons and form inputs. Overall, this is well-organized frontend styling with good attention to usability and maintainability.
|
Great PR! Currently im on a long OOF, so I wont have time to uodate version. Also the current kive version its an old one, and thays another problem ill had to face when merging (the SSO feature been disabled). Thank you for your time! |
| return RedirectResponse(url="/Frontend/index.html") | ||
|
|
||
|
|
||
| @app.get("/favicon.ico", include_in_schema=False) |
There was a problem hiding this comment.
Nice thinking I wanted to do that long time ago haha
SummaryResolved merge conflict with Merge conflict resolution —
|
3 participants
IMPORTANT: Opus 4.7 VIBE coding
CSS & frontend refactor
Cleanup pass across the
Frontend/tree — no behavior changes, just dedup and dead-code removal.CSS
.errorconsolidated — was defined twice; now lives incomponents.css.style.csskeeps a single#error { display: none; }override for the Control Panel placeholder..add-buttoncollapsed into.btn-primary— added a.btn-primary--smmodifier incomponents.cssfor the smaller padding/font variant; removed the duplicate block fromstyle.css.style.css:.success-message, .error-message {}empty stub.empty-state(used hardcoded color).room-numberdefinitions into one@media (max-width: 1200px)block with stray}.dark-mode .logo { filter: brightness(1); }— identity filter, no-op.dark-mode .Xoverrides — all 14 have legitimately different values from their light-mode bases, kept as-is.Shared page chrome
Frontend/js/chrome.jscentralizes:localStorage, apply.dark-modeto<body>)#dark-mode-toggleexists on the page).menu-button/.sidebarexist)admin.html,chat.html,credits.html,premium.html,whats_new.html, andindex.html(also dropped the menu-toggle block fromindex.html).<head>consistency<script src="js/chrome.js" defer></script>to all six pages.<link>tocredits.html.Backend
/favicon.icoroute inserver.pythat redirects to/Frontend/Images/favicon.ico— silences the browser's root-level favicon 404s.