mcobbett merge cli repo into galasa repo#245
Merged
Merged
Conversation
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
Update CLI workflow for stories 1966, 1965 and 1958
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
Added new users command to cli
* Use cursor-based pagination when getting runs from the API server Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com> * Remove includeCursor query parameter Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com> * Swap cursor condition order Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com> * Turn on includeCursor parameter Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com> * Remove log statement Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com> * Use 'from:desc' as the default sort for runs get Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com> --------- Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
…r to have any effect (#275) Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
* handle properties which have newlines or are very long better. Cropping text in the summary view. * explained away the interesting transform of apiversion to apiVersion in comments --------- Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
Iss1982 - Add copyright and remove argo app param
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
Disabling gradle cache to avoid build problems
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
Change the CLI's base image to ubuntu so it has bash
* makefile improvements, runs delete, unit tests missing. Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com> * some corrections of PR comments. Some error handling to do still Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com> * Add initial unit tests for runs delete Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com> * Make sure Mocks are not included in code coverage statistics Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com> * test coverage ignores ixture files. Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com> * Add more runs delete unit tests Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com> * Rework runs delete unit tests to use HTTP interactions Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com> * Close the test server in runs delete tests Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com> * Fix 'runs delete' not exiting with a cobra error when not specifying --name Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com> * Initial mocking-out of io.ReadAll in runs delete, added runs delete to readme Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com> * Add runs delete CLI tests to test-ecosystem script Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com> * Check if run has been deleted in test-ecosystem script Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com> * Add unit test for deleting reruns Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com> * Make runs submit print result summary to stdout, interim report messages go to log instead of stdout Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com> * Disable gradle cache Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com> --------- Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com> Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com> Co-authored-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
Remove maven cache
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
Install ca certs into galasactl images
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
Remove isolated trigger at end of Main build workflow
CLI now supports streams command
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
Added streams delete command
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
…galasa-repo-jade Iss2165 - Updates to GH workflows for the CLI module
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
… repo Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
…t can build now. Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
jadecarino
requested changes
Apr 16, 2025
Member
There was a problem hiding this comment.
- need to bring back the READMEmd accidentally deleted
- need to delete
.DS_Store - need to delete .github/workflows/build.yml (is a duplicate of cli.yaml)
- need to delete .github/workflows/codeql.yml (is a duplicate of cli-codeql.yaml)
- need to delete .github/workflows/pr-build.yml (is a duplicate of pr-cli.yaml)
- need to delete the
.gradledirectory - need to delete the
.vscode/settings.json - fix the .gitignore file
… the CLI code was merged Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
jadecarino
approved these changes
Apr 16, 2025
jadecarino
added a commit
to jadecarino/galasa
that referenced
this pull request
Apr 16, 2025
…e CLI in Pull Requests Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
techcobweb
added a commit
that referenced
this pull request
Apr 16, 2025
…always-build-cli Remove temporary change added in pr #245
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why ?
See CLI module should be moved to the galasa mono-repo #2165