Added new endpoint to cancel grouped runs#292
Conversation
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
jadecarino
left a comment
jadecarino
left a comment
There was a problem hiding this comment.
Hi Ash, good work, I have a few comments throughout, but they are all related to one of two questions I have about the work item itself, that perhaps if I understand better, will address my comment.
-
Is this work item meant to include resetting runs by their groupId or just cancelling them? The story only mentions cancelling them, but if you have had a separate discussion about including resetting also, thats fine.
-
My main question - how is the processing of the request and returning of a response meant to work? A groupId is provided to the API, which finds a list of matching runs. Then that list is looped through and each individual run is attempted to cancel. Are we trying to send multiple responses back to the client for if each run was successfully cancelled/not cancelled due to error, or are we meant to be combining this into a "overall" response and sending that back? This will help me understand better whats trying to be achived.
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
jadecarino
left a comment
jadecarino
left a comment
There was a problem hiding this comment.
Hi Ash, just a few small changes, and also a question perhaps just to help my understanding of whats going on. Thanks!
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
jadecarino
left a comment
jadecarino
left a comment
There was a problem hiding this comment.
Looks good! Thanks for making these changes Ash
…inId CLI now supports access tokens by loginId
2 participants
Why?
Signed-off-by: Aashir Siddiqui aashir_sidiki@hotmail.com