HTTP Manager: TLS + postForm + timeout + clearcookie + redirectstrategy#593
Merged
Merged
Conversation
99244b9 to
be99508
Compare
eamansour
reviewed
May 14, 2026
Member
eamansour
left a comment
There was a problem hiding this comment.
Thanks for contributing these changes, Mark! They look great overall, just a couple of very minor comments - I'll be happy to approve once they're sorted out
0b5ca08 to
e738f85
Compare
Signed-off-by: Mark Lawrence <mark.j.lawrence@ibm.com>
Signed-off-by: Mark Lawrence <mark.j.lawrence@ibm.com>
e738f85 to
c0cec47
Compare
Signed-off-by: Mark Lawrence <mark.j.lawrence@ibm.com>
951d2b6 to
1894985
Compare
eamansour
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
This PR delivers a number of changes which have been required whilst migrating our tests over from using the v4 HTTP client, and our own internal v5 HTTP client, over to the new public httpclient5 HTTP manager delivered in 0.47.0.
The changes are:
postForm()handler which makes working with encoded forms a lot easier (simply provide a url and a key-value map for the form)/, however, the trailing/is lost and it simply goes back to the baseUrl, causing failures.Changes