Skip to content

feat: add tiered level cell to the assembly and organism detail tables (#1386)#1390

Merged
NoopDog merged 1 commit into
mainfrom
fran/1386-level-tiered-icon
Jun 26, 2026
Merged

feat: add tiered level cell to the assembly and organism detail tables (#1386)#1390
NoopDog merged 1 commit into
mainfrom
fran/1386-level-tiered-icon

Conversation

@frano-m

@frano-m frano-m commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Summary

Replaces the plain-text Level column with a tiered bar indicator + label, per the Figma design, on both the catalog assembly list and the organism detail assembly table (BRC + GA2).

Closes #1386

What changed

  • New cell C.LevelCell (app/components/Table/components/TableCell/components/LevelCell/): 4 rounded bars (5×12px), first N filled PALETTE.PRIMARY_MAIN, rest PALETTE.SMOKE_DARK, followed by the level label — matching the Figma spec.
  • Builder buildLevel repurposed to return LevelCell props via a tier map: Complete Genome → 4, Chromosome → 3, Scaffold → 2, Contig → 1 (label = the actual NCBI level value; unknown → 0 bars).
  • Wired into all four Level columns: BRC genomeEntityConfig, GA2 columnDefs, and the BRC + GA2 organism-detail tables (buildOrganismGenomesTableColumns).

Design

  • Figma node.
  • Labels use the actual NCBI values (Complete Genome / Chromosome / Scaffold / Contig) — consistent with the Level filter and catalog data — rather than the Figma node's friendlier relabels (Genome / Foundation).

Tests

  • tests/viewModelBuilders/level.test.ts — pins the level → filled-bar mapping (incl. unknown → 0).
  • Full unit suite: 566 passing. tsc + lint clean.

🤖 Generated with Claude Code

image image image image

Copilot AI review requested due to automatic review settings June 26, 2026 12:07
@github-actions github-actions Bot added the feat label Jun 26, 2026
@frano-m frano-m moved this to Ready for Review in BRC development tasks Jun 26, 2026
@frano-m frano-m marked this pull request as ready for review June 26, 2026 12:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a shared “tiered level” table cell for NCBI assembly levels and wires it into both the catalog assemblies list and organism detail assembly tables (BRC + GA2), replacing the prior plain-text Level rendering.

Changes:

  • Introduces LevelCell (4-bar indicator + label) and exports it via the app/components barrel.
  • Repurposes buildLevel to map NCBI assembly levels → filled bar count and return LevelCell props.
  • Updates BRC/GA2 column configurations and organism-detail table columns to render the new LevelCell, with a unit test pinning the mapping behavior.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/viewModelBuilders/level.test.ts Adds unit coverage for level → filled-bar mapping (including unknown levels).
site-config/ga2/local/index/genome/columnDefs.ts Switches GA2 assemblies list Level column to render LevelCell.
site-config/brc-analytics/local/index/genomeEntityConfig.ts Switches BRC assemblies list Level column to render LevelCell.
app/viewModelBuilders/catalog/ga2/viewModelBuilders.ts Adds Level column rendering to GA2 organism detail genomes table using LevelCell.
app/viewModelBuilders/catalog/brc-analytics-catalog/common/viewModelBuilders.ts Updates buildLevel to return LevelCell props and adds the level→tier map.
app/components/Table/components/TableCell/components/LevelCell/types.ts Defines LevelCellProps (filledCount, label).
app/components/Table/components/TableCell/components/LevelCell/levelCell.tsx Implements the tiered 4-bar indicator + label cell renderer.
app/components/Table/components/TableCell/components/LevelCell/levelCell.styles.ts Adds styling for filled/unfilled bar segments (palette + dimensions).
app/components/Table/components/TableCell/components/LevelCell/constants.ts Defines the fixed bar count (4).
app/components/index.ts Exports LevelCell from the app components barrel for config usage.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

#1386)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@NoopDog NoopDog force-pushed the fran/1386-level-tiered-icon branch from de1ea03 to e6b348c Compare June 26, 2026 16:14
@NoopDog NoopDog merged commit ec5ea04 into main Jun 26, 2026
5 checks passed
@github-project-automation github-project-automation Bot moved this from Ready for Review to Done in BRC development tasks Jun 26, 2026
@frano-m frano-m deleted the fran/1386-level-tiered-icon branch June 27, 2026 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Level column: add to organism detail table and update the assembly list display (tiered icon)

3 participants