feat: add tiered level cell to the assembly and organism detail tables (#1386)#1390
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a shared “tiered level” table cell for NCBI assembly levels and wires it into both the catalog assemblies list and organism detail assembly tables (BRC + GA2), replacing the prior plain-text Level rendering.
Changes:
- Introduces
LevelCell(4-bar indicator + label) and exports it via theapp/componentsbarrel. - Repurposes
buildLevelto map NCBI assembly levels → filled bar count and returnLevelCellprops. - Updates BRC/GA2 column configurations and organism-detail table columns to render the new
LevelCell, with a unit test pinning the mapping behavior.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/viewModelBuilders/level.test.ts | Adds unit coverage for level → filled-bar mapping (including unknown levels). |
| site-config/ga2/local/index/genome/columnDefs.ts | Switches GA2 assemblies list Level column to render LevelCell. |
| site-config/brc-analytics/local/index/genomeEntityConfig.ts | Switches BRC assemblies list Level column to render LevelCell. |
| app/viewModelBuilders/catalog/ga2/viewModelBuilders.ts | Adds Level column rendering to GA2 organism detail genomes table using LevelCell. |
| app/viewModelBuilders/catalog/brc-analytics-catalog/common/viewModelBuilders.ts | Updates buildLevel to return LevelCell props and adds the level→tier map. |
| app/components/Table/components/TableCell/components/LevelCell/types.ts | Defines LevelCellProps (filledCount, label). |
| app/components/Table/components/TableCell/components/LevelCell/levelCell.tsx | Implements the tiered 4-bar indicator + label cell renderer. |
| app/components/Table/components/TableCell/components/LevelCell/levelCell.styles.ts | Adds styling for filled/unfilled bar segments (palette + dimensions). |
| app/components/Table/components/TableCell/components/LevelCell/constants.ts | Defines the fixed bar count (4). |
| app/components/index.ts | Exports LevelCell from the app components barrel for config usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
#1386) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
de1ea03 to
e6b348c
Compare
NoopDog
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the plain-text Level column with a tiered bar indicator + label, per the Figma design, on both the catalog assembly list and the organism detail assembly table (BRC + GA2).
Closes #1386
What changed
C.LevelCell(app/components/Table/components/TableCell/components/LevelCell/): 4 rounded bars (5×12px), first N filledPALETTE.PRIMARY_MAIN, restPALETTE.SMOKE_DARK, followed by the level label — matching the Figma spec.buildLevelrepurposed to returnLevelCellprops via a tier map: Complete Genome → 4, Chromosome → 3, Scaffold → 2, Contig → 1 (label = the actual NCBI level value; unknown → 0 bars).genomeEntityConfig, GA2columnDefs, and the BRC + GA2 organism-detail tables (buildOrganismGenomesTableColumns).Design
Tests
tests/viewModelBuilders/level.test.ts— pins the level → filled-bar mapping (incl. unknown → 0).tsc+ lint clean.🤖 Generated with Claude Code