feat: remove unused read count json and its builder (#1379)#1392
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the legacy, build-time precomputation and checked-in JSON artifacts for ENA read-run counts, which are no longer used after switching the stepper to a live ENA /count gate (per #1378 / issue #1379).
Changes:
- Deletes the Python read-run count builder/merger pipeline and its generated JSON outputs (BRC, GA2, and merged frontend artifact).
- Updates NCBI-build entrypoints to stop producing read-run count intermediates and updates
package.jsonscripts to stop invoking the merge step. - Minor comment cleanup in the frontend query hook.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Removes merge step from build-*-from-ncbi scripts. |
| catalog/py_package/catalog_build/build.py | Deletes taxonomy read-run count generation functions. |
| catalog/build/py/build_files_from_ncbi.py | Stops invoking read-run count generation for BRC build. |
| catalog/ga2/build/py/build_files_from_ncbi.py | Stops invoking read-run count generation for GA2 build. |
| catalog/build/py/mergeBRCandGA2ReadCounts.py | Deletes the merge script that produced the frontend JSON. |
| catalog/build/intermediate/taxIdReadCount.json | Removes generated BRC intermediate read-count output. |
| catalog/ga2/build/intermediate/taxIdReadCount.json | Removes generated GA2 intermediate read-count output. |
| app/.../ENASequencingData/query/taxonomy_read_counts.json | Removes the merged frontend read-count JSON artifact. |
| app/.../ENASequencingData/query/hook.ts | Updates comment text to reflect the live-count approach. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
NoopDog
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the precomputed ENA read run counts, which are unused following #1378
Related Issue
Closes #1379