Migrate Workflow Components from BTable to GTable#22228
Merged
itisAliRH merged 13 commits intogalaxyproject:devfrom Apr 7, 2026
Merged
Migrate Workflow Components from BTable to GTable#22228itisAliRH merged 13 commits intogalaxyproject:devfrom
itisAliRH merged 13 commits intogalaxyproject:devfrom
Conversation
itisAliRH
added
area/UI-UX
kind/refactoring
45 tasks
ahmedhamidawan
approved these changes
Mar 31, 2026
Member
ahmedhamidawan
left a comment
ahmedhamidawan
left a comment
There was a problem hiding this comment.
Other than these minor typing suggestions (and I also pushed 1 tiny commit which is kind of unrelated but no-wraps the JobState), this looks good to me! Thank you!
Member
|
@itisAliRH can you take a look at Ahmed's comments ? |
- Updated the component to use GTable instead of BTable for improved functionality. - Removed unused imports and cleaned up the showRowDetails function. - Adjusted the template to reflect changes in the table structure.
- Removed BTable component and replaced it with GTable for improved functionality. - Updated fields definition to include new sortable columns. - Adjusted event handling for row clicks and sorting. - Modified styles to align with GTable's structure.
- Changed import paths to use absolute paths for consistency. - Modified jobClicked function to accept an event object for better clarity. - Cleaned up the template by ensuring proper binding for row-click events.
- Updated the ParameterStep component to use GTable instead of BTable. - Adjusted the fields and props to align with GTable's requirements. - Improved code readability and consistency by removing unused imports.
- Changed props definition to use an interface for better clarity and type safety. - Enhanced code readability by organizing the structure of the component.
- Add isInputParameter function to check for input parameters. - Update template to handle unsupported input/output values gracefully.
- Refined the JOB_ROW selector in JobStep.test.ts and JobStepJobs.test.ts to exclude detail and empty rows, ensuring accurate job state representation in the tests.
Co-authored-by: Ahmed Hamid Awan <qe66653@umbc.edu>
itisAliRH
force-pushed
the
btable-to-gtable-workflows
branch
from
995399f to
89eceda
Compare
Member
Author
|
@ahmedhamidawan Thanks Ahmed! I applied the suggestions👍🏻 |
github-project-automation
Bot
moved this from Needs Review
to Done
in Galaxy Dev - weeklies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates workflow-related components (
Workflow/Import/TrsSearch.vue,WorkflowInvocationState/JobStepJobs.vue, andWorkflowInvocationState/ParameterStep.vue) from Bootstrap-Vue's components to ourGTable` as part of the ongoing effort tracked in #21703How to test the changes?
(Select all options that apply)
License