Add SMB file source implementation and template#22274
Draft
bernt-matthias wants to merge 1 commit intogalaxyproject:devfrom
Draft
Add SMB file source implementation and template#22274bernt-matthias wants to merge 1 commit intogalaxyproject:devfrom
bernt-matthias wants to merge 1 commit intogalaxyproject:devfrom
Conversation
9fdc986 to
677abc4
Compare
677abc4 to
ad0c944
Compare
Contributor
Author
|
During experimenting I stumbled over the following error (probably due to a misconfiguration) But it made me think what this credential cache is ... if |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to opencode + blablador.
I have manually tested upload from a SMB server in my network. Could try to work on (let work on) adding tests (but we would need to spin up a SMB instance in tests).
How to test the changes?
(Select all options that apply)
License