Skip to content

Add SMB file source implementation and template#22274

Draft
bernt-matthias wants to merge 1 commit intogalaxyproject:devfrom
bernt-matthias:samba-fs
Draft

Add SMB file source implementation and template#22274
bernt-matthias wants to merge 1 commit intogalaxyproject:devfrom
bernt-matthias:samba-fs

Conversation

@bernt-matthias
Copy link
Copy Markdown
Contributor

Thanks to opencode + blablador.

I have manually tested upload from a SMB server in my network. Could try to work on (let work on) adding tests (but we would need to spin up a SMB instance in tests).

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@bernt-matthias
Copy link
Copy Markdown
Contributor Author

During experimenting I stumbled over the following error (probably due to a misconfiguration)

smbprotocol.exceptions.SMBAuthenticationError: Failed to authenticate with server: SpnegoError (1): SpnegoError (16): Operation not supported or available, Context: No username or password was specified and the credential cache did not exist or contained no credentials, Context: Unable to negotiate common mechanism

But it made me think what this credential cache is ... if smbprotocol has such a thing, then we maybe/probably want to disable it.

@bernt-matthias
Copy link
Copy Markdown
Contributor Author

@bernt-matthias bernt-matthias marked this pull request as draft April 1, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Needs Review

Development

Successfully merging this pull request may close these issues.

1 participant