Skip to content

Improve pairing wizard UX#22295

Merged
mvdbeek merged 5 commits intogalaxyproject:devfrom
nekrut:pairing_wizard_tweaks
Apr 6, 2026
Merged

Improve pairing wizard UX#22295
mvdbeek merged 5 commits intogalaxyproject:devfrom
nekrut:pairing_wizard_tweaks

Conversation

@nekrut
Copy link
Copy Markdown
Contributor

@nekrut nekrut commented Mar 29, 2026

Summary

  • Add help text under filter boxes explaining how to enter forward/reverse pair naming patterns
  • Update paired datasets card description with Illumina/ElementBio examples
  • Display unmatched datasets as a bulleted list instead of inline comma-separated text

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. Navigate to /collection/new_list?advanced=true (by selecting a few datasets from your history, and choosing the "Advanced Build List" selection operation)
    2. Select "List of Paired Datasets" on the list builder
    3. Verify help text appears below filter boxes on auto-pairing step
    4. Verify unmatched datasets render as a bulleted list

🤖 Generated with Claude Code

@ahmedhamidawan
Copy link
Copy Markdown
Member

ahmedhamidawan commented Mar 30, 2026

Update: I have removed the alert that indicates this

Outdated: Added a change here for when the source items for list creation are not from the current history (the created collection still goes to the current history even if the source one is different):

pairing_wizard_tweaks.mp4

Copy link
Copy Markdown
Member

@ahmedhamidawan ahmedhamidawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than minor tweaks I added (as mentioned in the comment above), the help text additions/improvements make sense to me!

@mvdbeek
Copy link
Copy Markdown
Member

mvdbeek commented Mar 31, 2026

Added a change here for when the source items for list creation are not from the current history (the created collection still goes to the current history even if the source one is different):

I don't think we should show this, that's a lot of text taking up a lot of space, why would you think that's not the behavior ? My usual comment, no one was concerned about this before it was mentioned ? :)

@ahmedhamidawan
Copy link
Copy Markdown
Member

Added a change here for when the source items for list creation are not from the current history (the created collection still goes to the current history even if the source one is different):

I don't think we should show this, that's a lot of text taking up a lot of space, why would you think that's not the behavior ? My usual comment, no one was concerned about this before it was mentioned ? :)

I just felt like it gives the user content that the output collection will go into the current history, and not the history the datasets are from.

I don't mind removing the alert. Would it be worth putting a warning ⚠️ icon on the top right with a tooltip still saying that or is there no need for that either.

@mvdbeek
Copy link
Copy Markdown
Member

mvdbeek commented Mar 31, 2026

I would not do that, we should keep warning for actual warnings.

nekrut and others added 5 commits March 31, 2026 10:50
- Add help text under filter boxes explaining forward/reverse pair naming
- Update paired datasets description with Illumina/ElementBio examples
- Display unmatched datasets as bulleted list instead of inline comma-separated

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
For some reason, we had these direction labels set as `display: none`.
@ahmedhamidawan ahmedhamidawan force-pushed the pairing_wizard_tweaks branch from 7018b6f to e7bc860 Compare March 31, 2026 15:50
@ahmedhamidawan
Copy link
Copy Markdown
Member

I would not do that, we should keep warning for actual warnings.

I have dropped the commit that adds the alert

@mvdbeek mvdbeek merged commit bb6490a into galaxyproject:dev Apr 6, 2026
34 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in Galaxy Dev - weeklies Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

3 participants