[26.0] Fix slow get_private_role_user_emails_dict query#22307
Merged
mvdbeek merged 1 commit intogalaxyproject:release_26.0from Apr 1, 2026
Merged
Conversation
4 tasks
…filter The function was doing a full table scan of all private role-to-email mappings on every call, even though each caller only needs a small subset. On large instances like usegalaxy.org this scans hundreds of thousands of rows unnecessarily. Pass role_ids at all non-admin call sites so the query uses an IN clause instead of scanning the entire user_role_association table. Fixes galaxyproject#20469 Fixes GALAXY-MAIN-11Q0
mvdbeek
force-pushed
the
fix_slow_get_private_role_user_emails_dict
branch
2 times, most recently
from
859cdcf to
2d1a47a
Compare
jdavcs
approved these changes
Apr 1, 2026
Member
jdavcs
left a comment
jdavcs
left a comment
There was a problem hiding this comment.
That makes sense, thank you! Although I can't remember why we returned the full set of private user/role associations. Probably just an oversight.
github-project-automation
bot
moved this from Needs Review
to Done
in Galaxy Dev - weeklies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
by passing role_ids filter
The function was doing a full table scan of all private role-to-email mappings on every call, even though each caller only needs a small subset. On large instances like usegalaxy.org this scans hundreds of thousands of rows unnecessarily.
Pass role_ids at all non-admin call sites so the query uses an IN clause instead of scanning the entire user_role_association table.
Fixes #20469
How to test the changes?
(Select all options that apply)
License