[26.0] Pass tool_uuid as proper query parameter instead of reusing URL path id#22309
Merged
mvdbeek merged 1 commit intogalaxyproject:release_26.0from Apr 7, 2026
Merged
Conversation
Fixes galaxyproject#22260. The show() and raw_tool_source() endpoints passed the URL path `id` as both tool_id and tool_uuid to _get_tool(), causing a ValueError when a non-UUID tool ID fell through to UUID parsing. Now tool_uuid is passed as a separate query parameter (matching the pattern already used by the build endpoint), and the frontend sends it accordingly. Also validates tool_uuid is a valid UUID before attempting lookup.
mvdbeek
force-pushed
the
worktree-fix-tool-uuid-22260
branch
from
5ace5a3 to
83ba481
Compare
jmchilton
approved these changes
Apr 7, 2026
github-project-automation
Bot
moved this from Needs Review
to Done
in Galaxy Dev - weeklies
|
This PR was merged without a "kind/" label, please correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22260. The show() and raw_tool_source() endpoints passed the URL path
idas both tool_id and tool_uuid to _get_tool(), causing a ValueError when a non-UUID tool ID fell through to UUID parsing.Now tool_uuid is passed as a separate query parameter (matching the pattern already used by the build endpoint), and the frontend sends it accordingly.
Also validates tool_uuid is a valid UUID before attempting lookup.
How to test the changes?
(Select all options that apply)
License