[26.0] Strip content-length and accept-ranges headers from proxied streaming responses#22314
Merged
dannon merged 1 commit intogalaxyproject:release_26.0from Apr 2, 2026
Conversation
… responses The proxy endpoint can truncate responses via MAX_STREAM_BYTES or MAX_STREAM_SECONDS limits. When content-length from the upstream was forwarded but the stream was cut short, uvicorn raised "LocalProtocolError: Too little data for declared Content-Length". Fix by always excluding content-length from forwarded headers. The StreamingResponse uses chunked transfer encoding instead, which tolerates early stream termination. Also strip accept-ranges since without content-length clients can't issue range requests anyway. HEAD responses still forward both headers unfiltered. Fixes galaxyproject#22313
github-project-automation
Bot
moved this from Needs Review
to Done
in Galaxy Dev - weeklies
|
This PR was merged without a "kind/" label, please correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proxy endpoint can truncate responses via MAX_STREAM_BYTES or MAX_STREAM_SECONDS limits. When content-length from the upstream was forwarded but the stream was cut short, uvicorn raised "LocalProtocolError: Too little data for declared Content-Length".
Fix by always excluding content-length from forwarded headers. The StreamingResponse uses chunked transfer encoding instead, which tolerates early stream termination. Also strip accept-ranges since without content-length clients can't issue range requests anyway. HEAD responses still forward both headers unfiltered.
Fixes #22313
How to test the changes?
(Select all options that apply)
License