[26.0] Wrap webhook scripts in IIFE to prevent redeclaration errors#22320
Open
mvdbeek wants to merge 2 commits intogalaxyproject:release_26.0from
Open
[26.0] Wrap webhook scripts in IIFE to prevent redeclaration errors#22320mvdbeek wants to merge 2 commits intogalaxyproject:release_26.0from
mvdbeek wants to merge 2 commits intogalaxyproject:release_26.0from
Conversation
Fixes SyntaxError: redeclaration of let tries in Firefox when webhook scripts are injected more than once via appendScriptStyle. Fixes https://sentry.galaxyproject.org/organizations/galaxy/issues/293105/
github-actions
bot
changed the title
Without the newlines, a webhook script ending in a line comment (// ...) would swallow the closing })(); and produce a SyntaxError.
dannon
approved these changes
Apr 1, 2026
Member
dannon
left a comment
dannon
left a comment
There was a problem hiding this comment.
Pushed a minor tweak dealing with a corner case of scripts ending in a line comment -- without newlines around the IIFE body, the closing })(); gets swallowed by the comment. Looks good, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SyntaxError: redeclaration of let tries in Firefox when webhook scripts are injected more than once via appendScriptStyle.
Fixes #22319
How to test the changes?
(Select all options that apply)
License