[26.0] Fix AbortSignal being serialized as dataset view query parameter#22326
Open
mvdbeek wants to merge 1 commit intogalaxyproject:release_26.0from
Open
[26.0] Fix AbortSignal being serialized as dataset view query parameter#22326mvdbeek wants to merge 1 commit intogalaxyproject:release_26.0from
mvdbeek wants to merge 1 commit intogalaxyproject:release_26.0from
Conversation
LastQueue passes an AbortSignal as the second positional argument to fetch handlers, but fetchDatasetDetails had `view: string` as its second parameter. This caused the AbortSignal object to be serialized into the query string, producing URLs like: /api/datasets/...?view[aborted]=false&view[throwIfAborted]=... Move `view` into the params object and accept the signal as the second argument, passing it through to openapi-fetch so requests are properly cancellable. Also update the FetchHandler type in keyedCache to reflect that handlers may receive a signal.
jmchilton
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LastQueue passes an AbortSignal as the second positional argument to fetch handlers, but fetchDatasetDetails had
view: stringas its second parameter. This caused the AbortSignal object to be serialized into the query string, producing URLs like:/api/datasets/...?view[aborted]=false&view[throwIfAborted]=...
Move
viewinto the params object and accept the signal as the second argument, passing it through to openapi-fetch so requests are properly cancellable. Also update the FetchHandler type in keyedCache to reflect that handlers may receive a signal.How to test the changes?
(Select all options that apply)
License