Unify path adaptation for remote file sources#22336
Merged
davelopez merged 1 commit intogalaxyproject:devfrom Apr 5, 2026
Merged
Unify path adaptation for remote file sources#22336davelopez merged 1 commit intogalaxyproject:devfrom
davelopez merged 1 commit intogalaxyproject:devfrom
Conversation
Refactors the remote file source adapters to consistently handle translation between virtual entry paths and physical filesystem paths. Introduces and standardizes methods to convert between virtual and storage-specific paths for S3, Azure, Google Cloud Storage, Hugging Face, SSH, and temporary file sources. Removes redundant or duplicate code, eliminates unnecessary intermediate path conversion helpers, and ensures that path adaptation logic always receives the configuration context it requires.
davelopez
added
kind/refactoring
4 tasks
mvdbeek
approved these changes
Apr 1, 2026
github-project-automation
bot
moved this from Needs Review
to Done
in Galaxy Dev - weeklies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the remote file source adapters to consistently handle translation between virtual entry paths and physical filesystem paths. Introduces and standardizes methods to convert between virtual and storage-specific paths. Removes redundant or duplicate code, eliminates unnecessary intermediate path conversion helpers, and ensures that path adaptation logic always receives the resolved configuration context with resolved templates for configuration values (addressing #21646 (comment)).
How to test the changes?
License