✨ Quality: Improve robustness - string transformations - #83
Conversation
- Add `.trim()` to `camelCase` and `pascalCase` transformations in `valueTransforms`. - Fixes a bug where leading spaces caused incorrect capitalization in `camelCase`. - Add test cases for leading/trailing spaces in `strings.test.ts`. - Standardize code style in `strings.ts` to match project conventions.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Added
.trim()tocamelCaseandpascalCasetransformations in thevalueTransformsutility.🎯 Why: Without trimming, leading whitespace would cause the first word's initial letter to have a match index > 0, leading the regex to capitalize it (e.g., " hello" became " Hello" instead of " hello").
📊 Impact: Ensures consistent and correct behavior for casing transformations when inputs have inconsistent whitespace. Improves code style consistency in the utilities directory.
✅ Verification: Added unit tests for
camelCaseandpascalCasewith leading/trailing spaces. Ran the full test suite (pnpm test) and verified the build (pnpm build).PR created automatically by Jules for task 16833917680317417700 started by @galiprandi