Skip to content

✨ Quality: robustness and documentation - useThrottle - #87

Merged
galiprandi merged 1 commit into
mainfrom
quality-usethrottle-improvement-16891675594808657242
Jun 10, 2026
Merged

✨ Quality: robustness and documentation - useThrottle#87
galiprandi merged 1 commit into
mainfrom
quality-usethrottle-improvement-16891675594808657242

Conversation

@galiprandi

Copy link
Copy Markdown
Owner

💡 What:

  • Added defensive validation for the limit parameter in the useThrottle hook to handle NaN, 0, and negative values.
  • Updated the useThrottle JSDoc to include the @default 500 tag for the limit parameter.
  • Added comprehensive unit tests for these edge cases in lib/hooks/useThrottle.test.ts.

🎯 Why:

  • The hook previously relied on native setTimeout behavior for invalid limit values, which can be inconsistent or result in unexpected 1ms/0ms delays.
  • Documentation was missing explicit information about the default limit value.
  • Unit tests were missing coverage for invalid numeric inputs, which are common when values are derived dynamically.

📊 Impact:

  • Robustness: The hook now predictably performs an immediate update when an invalid limit is provided.
  • Maintainability: Better documentation and 100% branch coverage for the hook's logic.
  • Consistency: The test file now follows the project's standard import patterns.

✅ Verification:

  • Ran pnpm test lib/hooks/useThrottle.test.ts (8 passed).
  • Verified 100% branch coverage with pnpm test:coverage.
  • Ran pnpm lint to ensure no regressions in code quality.

PR created automatically by Jules for task 16891675594808657242 started by @galiprandi

- Improved useThrottle robustness by handling NaN, zero, and negative limit values.
- Updated JSDoc with @default 500 for the limit parameter.
- Enhanced test coverage in useThrottle.test.ts to include edge cases (NaN, negative limits).
- Maintained 100% branch coverage for useThrottle.ts.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@galiprandi
galiprandi merged commit f01b4b2 into main Jun 10, 2026
4 checks passed
@galiprandi
galiprandi deleted the quality-usethrottle-improvement-16891675594808657242 branch June 15, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant