✨ Quality: robustness and documentation - useThrottle - #87
Conversation
- Improved useThrottle robustness by handling NaN, zero, and negative limit values. - Updated JSDoc with @default 500 for the limit parameter. - Enhanced test coverage in useThrottle.test.ts to include edge cases (NaN, negative limits). - Maintained 100% branch coverage for useThrottle.ts.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
limitparameter in theuseThrottlehook to handleNaN,0, and negative values.useThrottleJSDoc to include the@default 500tag for thelimitparameter.lib/hooks/useThrottle.test.ts.🎯 Why:
setTimeoutbehavior for invalidlimitvalues, which can be inconsistent or result in unexpected 1ms/0ms delays.limitvalue.📊 Impact:
limitis provided.✅ Verification:
pnpm test lib/hooks/useThrottle.test.ts(8 passed).pnpm test:coverage.pnpm lintto ensure no regressions in code quality.PR created automatically by Jules for task 16891675594808657242 started by @galiprandi