Fix: safe tooltip pipeline overwrite + menu/play/referral/pending-action hardening - #108
Conversation
|
CodeAnt AI is reviewing your PR. Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…for-runewager-bot-o35p2n
Nitpicks 🔍
|
|
CodeAnt AI finished reviewing your PR. |
User description
Motivation
python3, and cannot accidentally commit unrelated staged files.Description
load_tooltips.shto enableset -euo pipefailat the top, usepython3 -m json.toolfor validation, write tooltips viacat > "$OUT"(overwrite), and added a staged-index guard to abort if files other than.gitignoreare staged; commits are scoped to.gitignoreonly and the script prints the same success message.clearOldMenus(ctx)andreplyMenu(...), added callback-query hygiene middleware to delete the source callback card before sending follow-ups, and switched menu renderers (settings, main, persistent) to usereplyMenuso old menus are removed before new ones are posted.getPlayMode,getPlayLink,getPlayButton,playButtonMarkup) and replaced all Play button usages so Browser mode uses a plainurlexternal link (https://runewager.com/r/GambleCodez) and Mini App mode usesweb_appmetadata; ensured settings toggle persists immediately and re-renders withclearOldMenus.getDiscordLink(...)sanitation to ensure Discord URLs are raw external HTTPS links, introducedACTION_LABELSand a robustevaluatePendingActionTimeout(...)with numeric coercion and exact-15-minute boundary semantics, and escaped referral codes inreferralShareHTML(...)to prevent HTML injection.test/unit.test.jsandtest/smoke.test.jsto cover tooltip loader presence, staged-guard behavior, menu hygiene, play-button determinism, catch-all regex detection, command extraction improvements, pending-action boundary and labeling, referral HTML escaping, and TestAll summary expectations.BOT_PRIVACY_MODE="disabled", removing legacyBOTPRIVACYMODEalias, and documenting core env keys used by runtime checks.Testing
npm test --silent, which completed successfully.load_tooltips.shsyntax withbash -n load_tooltips.shand validated the script writes/overwrites/var/www/html/Runewager/data/tooltips.jsonand validates it withpython3 -m json.tool.Codex Task
CodeAnt-AI Description
Prevent accidental commits when running the tooltip loader script
What Changed
Impact
✅ No accidental commits during tooltip updates✅ Clearer failure message when other files are staged✅ Safer tooltip deployment💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.