Claude/update prod runner script lq2g s

[gamblecodezcom]

CodeAnt-AI Description

Ensure deploy script inherits bot env and make deploy/maintenance more robust

What Changed

• The bot's /deploy command now launches the deploy script with the bot's environment so Telegram admin notifications from the script reliably reach configured admins.
• The deploy script only parses BOT_TOKEN and ADMIN_IDS from .env when those variables are not already present, avoiding accidental overwrites when the bot spawns the script; those variables are exported for the script's notification helper.
• Disk maintenance now treats npm cache-clean failures as non-fatal so the cleanup run won't fail if npm errors.
• The CI deploy job no longer binds to a GitHub "production" environment name, reducing chances of environment-protection blocks during the deploy workflow.

Impact

✅ Reliable admin deploy notifications
✅ Fewer failed maintenance runs due to npm errors
✅ Fewer blocked CI deploys from environment protection

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Summary by CodeRabbit

• Bug Fixes

  • Improved deployment script robustness by preventing non-fatal errors during cache operations from interrupting the deployment process.

• Chores

  • Enhanced environment variable handling in deployment workflow.
  • Updated deployment configuration for improved environment management.

[codeant-ai]

CodeAnt AI is reviewing your PR.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between 8f7133c and 19ed73f.

📒 Files selected for processing (4)

• .github/workflows/deploy.yml
• deploy.sh
• index.js
• scripts/disk-protect.sh

---

📝 Walkthrough

Walkthrough

This PR modifies environment variable handling across deployment scripts and CI/CD configuration. The GitHub Actions deploy job no longer explicitly binds to a production environment, deploy.sh now conditionally loads BOT_TOKEN and ADMIN_IDS only if not already set, index.js passes explicit environment variables to the spawned deploy.sh process, and disk-protect.sh makes npm cache operations non-fatal.

Changes

Cohort / File(s)	Summary
CI/CD Configuration .github/workflows/deploy.yml	Removed environment binding for the Deploy job, eliminating the explicit production environment block.
Environment Variable Handling deploy.sh, index.js	Modified conditional loading of BOT_TOKEN and ADMIN_IDS in deploy.sh to skip overwriting if already set. Updated index.js to pass explicit env object (spreading process.env and ensuring PATH) to spawned deploy.sh subprocess.
Script Robustness scripts/disk-protect.sh	Added error suppression (`

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 Environment variables dance with care,
No forced overwrites in the mountain air,
Deploy subprocess gets its PATH set straight,
Cache failures won't seal our fate,
Scripts now coexist in harmony! 🌿

---

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codeant-ai]

Sequence Diagram

The PR ensures the bot's /deploy command launches deploy.sh as a detached process that inherits BOT_TOKEN and ADMIN_IDS (and PATH), and the script only parses .env when those variables are missing — allowing deploy.sh to send silent Telegram admin notifications and perform the stop/start deployment steps.

sequenceDiagram
    participant Admin
    participant Bot
    participant deploy_sh as deploy.sh
    participant Telegram
    participant System

    Admin->>Bot: /deploy command
    Bot->>Bot: Persist runtime state & reply "Deployment starting"
    Bot->>deploy_sh: Spawn detached deploy.sh (env includes BOT_TOKEN, ADMIN_IDS, PATH)
    deploy_sh->>deploy_sh: Load BOT_TOKEN/ADMIN_IDS from env or .env (only if missing)
    deploy_sh->>Telegram: send_admin(...) (silent admin notifications)
    deploy_sh->>System: stop/start service / run deployment steps

Loading

---

Generated by CodeAnt AI

[codeant-ai]

Nitpicks 🔍

🔒 No security issues identified

⚡ Recommended areas for review Potential token exposure risk The script reads BOT_TOKEN from disk and exports it into the environment. If this script can be run by non-privileged users or output/error streams are captured, that token could be exposed. Ensure file permissions and execution contexts are controlled and consider limiting exporting the token only when necessary. .env parsing edge cases The new dotenv parsing only matches lines beginning exactly with BOT_TOKEN= / ADMIN_IDS=. It will miss common variants such as export BOT_TOKEN=... or lines with leading whitespace. It may also skip values that are preceded by whitespace or export. Confirm .env formats you need to support (exported variables, commented lines, whitespace) and update the extraction to handle them. Incomplete value trimming/quoting The current extraction pipeline strips surrounding quotes via sed and CRs via tr, but may still leave leading/trailing whitespace. Consider normalizing whitespace and supporting values that contain = characters (cut -d= -f2- already handles = in values, but validate in tests). npm cache logging suppressed The change pipes npm cache clean through tail -1, which only logs the last line of output. That hides potentially useful diagnostics. Also, because set -o pipefail is enabled, ensure the pipeline failure doesn't abort the script (the PR added || true but confirm that behavior is desired).

[codeant-ai]

CodeAnt AI finished reviewing your PR.