Claude/update prod runner script lq2g s

[gamblecodezcom]

User description

Summary by CodeRabbit

• New Features

  • Automatic weekly disk space cleanup to optimize system storage and prevent disk-related issues.

• Improvements

  • Enhanced deployment notifications with detailed status messages at key stages.
  • Improved error recovery mechanisms for automatic service restart on deployment failures.
  • Added comprehensive health checks and status verification after deployments.

---

CodeAnt-AI Description

Improve VPS deploy reliability, add weekly disk cleanup, and harden runtime safety

What Changed

• Deploys now detect service status and skip or restart the service as appropriate; failed deploy attempts notify admins and attempt to recover the running service automatically
• Deployment script uses safer environment parsing, supports SSH key then password fallback, sends clear pre/post notifications, runs a health check after deploy, and performs deterministic rollback on failure
• Adds a weekly disk-protection script and installs a weekly cron job to compress/remove old logs, vacuum system journal, clear npm cache/temp files, and remove old runtime snapshots without touching critical files
• Bot runtime adjustments: tips scheduler starts at launch, persistent state load/save behavior tightened, health endpoint simplified, periodic persistence interval increased (less frequent disk writes)
• Better admin messaging across CI and deploy flows (more structured start/finish/status messages and final deploy reports)

Impact

✅ More reliable VPS deploys with automatic recovery
✅ Fewer out-of-disk incidents via weekly cleanup
✅ Clearer deploy and health notifications for admins

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[coderabbitai]

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between f111531 and 9765a19.

📒 Files selected for processing (5)

• .github/workflows/deploy.yml
• deploy.sh
• index.js
• prod-run.sh
• scripts/disk-protect.sh

---

📝 Walkthrough

Walkthrough

This pull request enhances deployment automation and system maintenance by introducing dynamic notification messaging in the CI/CD workflow with granular step updates, improving service recovery and dependency management in the deployment script, and adding a new disk-space protection mechanism via a dedicated maintenance script and cron job.

Changes

Cohort / File(s)	Summary
CI/CD Workflow Enhancement .github/workflows/deploy.yml	Replaces static notifications with dynamic MSG variable construction. Expands Job 2 with explicit Production environment, adds messaging at each deploy phase (SSH setup, health checks, rollback), and introduces intermediate notifications for key-based and password-fallback SSH attempts.
Deployment Script Robustness deploy.sh	Introduces environment parsing from .env for BOT_TOKEN and ADMIN_IDS. Adds service recovery tracking with _SERVICE_STOPPED flag and enhanced error handling. Improves skip-logic to consider service status. Unifies npm command selection and adds npm failure recovery with service restart fallback.
Disk-Space Management prod-run.sh, scripts/disk-protect.sh	Adds weekly cron job (03:00) via prod-run.sh to invoke new disk-protect.sh script. New script manages disk usage through log compression, log rotation, journalctl vacuuming, npm cache clearing, temp file removal, and snapshot cleanup with comprehensive logging and safety checks.

Sequence Diagram(s)

sequenceDiagram
    participant GH as GitHub Actions
    participant Deploy as deploy.sh
    participant Env as .env Parser
    participant Bot as Bot Service
    participant SSH as SSH/VPS
    participant TG as Telegram Notify

    GH->>Deploy: Start Deployment
    Deploy->>Env: Parse BOT_TOKEN, ADMIN_IDS
    Env-->>Deploy: Env Loaded
    Deploy->>TG: Send Deploy Start Notification
    Deploy->>Bot: Stop Service (_SERVICE_STOPPED=true)
    Deploy->>SSH: Attempt Key-Based SSH
    alt SSH Key Success
        SSH-->>Deploy: Connected
        Deploy->>TG: SSH Success Notification
    else SSH Key Fails
        Deploy->>SSH: Attempt Password Fallback
        alt Password Success
            SSH-->>Deploy: Connected
            Deploy->>TG: Password Fallback Success
        else Password Fails
            Deploy->>TG: Deploy Failed Notification
            Deploy->>Bot: Restart Service (Recovery)
            Deploy-->>GH: Exit with Error
        end
    end
    Deploy->>Bot: Fetch, Reset, Install Dependencies
    Bot-->>Deploy: Dependencies Ready
    Deploy->>Bot: Start Service (_SERVICE_STOPPED=false)
    Deploy->>TG: Health Check Notification
    Deploy->>TG: Final Deploy Report (Status, Commit, Version)
    Deploy-->>GH: Deployment Complete

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Poem

🐰 Hops through deploys with messages bright,
Service recovery keeps bots running right,
Disks protected with weekly care,
Logs compressed with logging to spare! 🚀

---

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codeant-ai]

CodeAnt AI is reviewing your PR.

[codeant-ai]

Nitpicks 🔍

🔒 No security issues identified

⚡ Recommended areas for review Sensitive data exposure The script reads BOT_TOKEN and ADMIN_IDS from .env and then exports them into the environment. Exporting secrets to process environment can increase exposure (e.g., visible in /proc//environ or to child processes). Consider minimizing the scope or avoiding export when not required. Error-trap robustness The ERR trap relies on BASH_LINENO and is registered with 'trap' after set -euo pipefail. Errors that occur in subshells or some command contexts may not trigger the trap as expected. Also BASH_LINENO semantics can be subtle. Verify the trap behaves reliably across failures (fetch/reset/npm/etc) and consider enabling errtrace so ERR propagates into functions/subshells. Cron execution environment The cron entry added for disk-protect invokes the script directly. Cron jobs have a minimal PATH and environment; if the script expects particular PATH or shell features, it may fail when run by cron. Also the cron line doesn't ensure the script is executable. Consider invoking the script with an explicit shell or full interpreter path and ensure executable permission.

[codeant-ai]

Suggestion: The log and warn helpers embed a date command with an unescaped inner double-quoted format string inside an outer double-quoted echo argument; this breaks shell quoting and will cause the script to fail to parse/execute, so the script will never run and the disk protection job will not perform any cleanup. [logic error]

Severity Level: Critical 🚨

- ❌ disk-protect.sh never runs; cron job always fails.
- ⚠️ Log rotation step at line 52 never executes.
- ⚠️ Log compression logic at lines 65–73 never executes.
- ⚠️ Old log deletion via delete_found at lines 79–82 skipped.
- ⚠️ journalctl vacuum at lines 85–89 never invoked.
- ⚠️ npm cache cleanup at lines 95–101 never invoked.
- ⚠️ Temp file cleanup under $DATA_DIR at lines 104–107 skipped.
- ⚠️ Old runtime-state backups under $BACKUP_DIR at lines 114–116 kept.
- ⚠️ Safety check for .env and runtime-state.json at lines 124–135 skipped.
- ⚠️ Disk usage summary logging at lines 139–145 never printed.

Suggested change

	log() { echo "[$(date -u +"%Y-%m-%dT%H:%M:%SZ")] [disk-protect] $*"; }
	warn() { echo "[$(date -u +"%Y-%m-%dT%H:%M:%SZ")] [disk-protect] WARN: $*" >&2; }
	log() { echo "[$(date -u '+%Y-%m-%dT%H:%M:%SZ')] [disk-protect] $*"; }
	warn() { echo "[$(date -u '+%Y-%m-%dT%H:%M:%SZ')] [disk-protect] WARN: $*"; }

Steps of Reproduction ✅

1. From the repository root `/workspace/Runewager`, execute `bash scripts/disk-protect.sh`
to run the disk protection script defined in `scripts/disk-protect.sh:1-148`.

2. Bash begins parsing the `log()` function at `scripts/disk-protect.sh:29`, which is
currently `log() { echo "[$(date -u +"%Y-%m-%dT%H:%M:%SZ")] [disk-protect] $*"; }`.

3. The command substitution `$(date -u +"%Y-%m-%dT%H:%M:%SZ")` contains an inner
double-quoted format string inside an outer double-quoted `echo` argument, breaking
quoting; Bash reports a syntax error while parsing this line and exits before running the
rest of the script.

4. Observe that no subsequent steps execute: the first `log "Step 1: Log rotation"` call
at `scripts/disk-protect.sh:52` never runs, the cleanup sections at lines 64–147 are
skipped, and the final `log "Disk protection complete."` at line 148 is never printed.

Prompt for AI Agent 🤖

This is a comment left during a code review.

**Path:** scripts/disk-protect.sh
**Line:** 29:30
**Comment:**
	*Logic Error: The `log` and `warn` helpers embed a `date` command with an unescaped inner double-quoted format string inside an outer double-quoted echo argument; this breaks shell quoting and will cause the script to fail to parse/execute, so the script will never run and the disk protection job will not perform any cleanup.

Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.

👍 | 👎

[codeant-ai]

CodeAnt AI finished reviewing your PR.

[gamblecodezcom]

All improvements from this PR have been cherry-picked and are already in main:

• disk-protect.sh: already in main with the same content + path fix (BASH_SOURCE[0])
• prod-run.sh: weekly disk-protect cron already in main
• index.js: expireReferralBoosts hourly + runWeeklyBoostReminder weekly intervals already in main
• deploy.yml: post-deploy health check already in main

The deploy.yml inline deploy commands in this branch also contained broad pkill -f node which was a regression vs the scoped pkill -f Runewager/index.js in main. Closing without merge.