Require setup-gap@v3 to simplify some code
#23
Conversation
fingolfin
changed the title
setup-gap@v3 to simplify some code
.github/workflows/CI.yml
Outdated
| - 4.13 | ||
| - 4.12 | ||
| - 4.11 | ||
| - 4.10 |
There was a problem hiding this comment.
ah, so this is interpreted as a float and thus changed to 4.1
There was a problem hiding this comment.
Sadly, yes. I don't think there's any way to avoid this other than quoting the inputs.
Maybe another thing to add to setup-gap's readme?
There was a problem hiding this comment.
Yes that should be in the README
stertooy
left a comment
stertooy
left a comment
There was a problem hiding this comment.
Looks good to me.
Tests are failing because Example requires GAP 4.11 or later, though. For now we could just test 4.11 or later. I think ideally we should move to using ActionTestGAPDocPackage (after making it compatible with earlier GAP versions?), but that's not urgent and certainly shouldn't hold this PR back.
|
Yeah, the Example package thing is my fault (gap-packages/example#49). Perhaps revert that if it was mistaken. |
|
@fingolfin Does this undo #22, i.e. |
|
@wilfwilson no this should not affect |
|
@fingolfin Never mind, I must have just been confused, maybe I was looking at the wrong tab or something. |
No description provided.