Skip to content

Replace ValueOption usage in C9 subgroup code with explicit option records#169

Merged
fingolfin merged 1 commit into
gap-packages:mainfrom
chseeger:cs/removeC9ValueOptions
May 18, 2026
Merged

Replace ValueOption usage in C9 subgroup code with explicit option records#169
fingolfin merged 1 commit into
gap-packages:mainfrom
chseeger:cs/removeC9ValueOptions

Conversation

@chseeger
Copy link
Copy Markdown
Collaborator

This PR removes the dependency on GAP's global Options Stack from the C9 subgroup code. It replaces ValueOption usage with explicit option records passed through the relevant internal C9 helper functions.

This is an internal refactor only:

  • no documented public API changes
  • no changes to ClassicalMaximalsGeneric

Behavior and defaults are unchanged:

  • all defaults to true
  • novelties defaults to false
  • special defaults to false
  • general defaults to false
  • normaliser defaults to false

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.81%. Comparing base (1ac2531) to head (2ecb2b5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
- Coverage   97.93%   97.81%   -0.13%     
==========================================
  Files          18       18              
  Lines        8629     8540      -89     
==========================================
- Hits         8451     8353      -98     
- Misses        178      187       +9     
Files with missing lines Coverage Δ
gap/AlmostSimpleCrossCharacteristic.gd 100.00% <ø> (ø)
gap/AlmostSimpleCrossCharacteristic.gi 96.14% <100.00%> (-2.90%) ⬇️
gap/AlmostSimpleDefiningCharacteristic.gi 98.82% <100.00%> (+0.02%) ⬆️
gap/ClassicalMaximals.gi 98.82% <ø> (-0.04%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fingolfin fingolfin linked an issue May 18, 2026 that may be closed by this pull request
@fingolfin fingolfin merged commit 9332ca4 into gap-packages:main May 18, 2026
4 checks passed
@chseeger chseeger deleted the cs/removeC9ValueOptions branch May 18, 2026 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reconsider API for ClassicalMaximalsGeneric options

2 participants