Skip to content

Declare recog as needed package and remove unnecessary dependencies#172

Merged
fingolfin merged 2 commits into
gap-packages:mainfrom
chseeger:cs/undeclaredRecogDependency
May 20, 2026
Merged

Declare recog as needed package and remove unnecessary dependencies#172
fingolfin merged 2 commits into
gap-packages:mainfrom
chseeger:cs/undeclaredRecogDependency

Conversation

@chseeger
Copy link
Copy Markdown
Collaborator

During automated package tests for the GAP package distribution (gap-system/PackageDistro#1376, Run tests with OnlyNeeded), it became apparent that the package relied on functionality from packages that were not listed in NeededOtherPackages.

In particular, the package directly uses the following functionality from recog:

  • RECOG.BaseChangeForSmallestPossibleField
  • RECOG.HomTensorFactor
  • RecogniseClassical

Therefore, recog >= 1.5.0 is now added to NeededOtherPackages in PackageInfo.g.

In addition, other avoidable package dependencies are removed by replacing

  • Degree with DimensionOfMatrixGroup
  • IsAbsolutelyIrreducible (from irredsol) with the underlying MTX-based implementation

(There also remains the separate issue that the test suite takes too long ...)

chseeger added 2 commits May 19, 2026 23:59
Replace calls to Degree and IsAbsolutelyIrreducible
to avoid unnecessary package dependencies
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.81%. Comparing base (5c9b7d8) to head (df6310a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #172   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files          18       18           
  Lines        8540     8540           
=======================================
  Hits         8353     8353           
  Misses        187      187           
Files with missing lines Coverage Δ
gap/AlmostSimpleCrossCharacteristic.gi 96.14% <100.00%> (ø)
gap/AlmostSimpleDefiningCharacteristic.gi 98.82% <100.00%> (ø)
gap/ClassicalMaximals.gi 98.82% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chseeger chseeger marked this pull request as ready for review May 20, 2026 11:48
@fingolfin fingolfin merged commit 4e256da into gap-packages:main May 20, 2026
4 checks passed
@chseeger chseeger deleted the cs/undeclaredRecogDependency branch May 20, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants