Declare recog as needed package and remove unnecessary dependencies#172
Merged
fingolfin merged 2 commits intoMay 20, 2026
Merged
Conversation
Replace calls to Degree and IsAbsolutelyIrreducible to avoid unnecessary package dependencies
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
=======================================
Coverage 97.81% 97.81%
=======================================
Files 18 18
Lines 8540 8540
=======================================
Hits 8353 8353
Misses 187 187
🚀 New features to boost your workflow:
|
fingolfin
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During automated package tests for the GAP package distribution (gap-system/PackageDistro#1376, Run tests with OnlyNeeded), it became apparent that the package relied on functionality from packages that were not listed in
NeededOtherPackages.In particular, the package directly uses the following functionality from
recog:RECOG.BaseChangeForSmallestPossibleFieldRECOG.HomTensorFactorRecogniseClassicalTherefore,
recog >= 1.5.0is now added toNeededOtherPackagesinPackageInfo.g.In addition, other avoidable package dependencies are removed by replacing
DegreewithDimensionOfMatrixGroupIsAbsolutelyIrreducible(fromirredsol) with the underlying MTX-based implementation(There also remains the separate issue that the test suite takes too long ...)