Skip to content

Restore compatibility with the matgrp package #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fingolfin merged 1 commit into from
May 19, 2026
Merged

Restore compatibility with the matgrp package #485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion gap/base/methods.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,22 @@ end);
InstallGlobalFunction(BindRecogMethod,
function(rname, arg...)
local r, name;
r := ValueGlobal(rname);
if IsString(rname) then
r := ValueGlobal(rname);
elif rname = FindHomMethodsMatrix and arg[1] = "Nonfield" and EndsWith(INPUT_FILENAME(), "recograt.gi") then
# FIXME/HACK: backwards compatibility for the matgrp package
rname := "FindHomMethodsMatrix";
r := FindHomMethodsMatrix;
arg[Length(arg)] :=
Comment thread
SoongNoonien marked this conversation as resolved.
function(ri)
if IsBound(ri!.ring) and not IsBound(ri!.field) then
Error("hereIAm");
Copy link
Copy Markdown
Collaborator

@SoongNoonien SoongNoonien May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this error mean? I see that it has been copied from matgrp but I'm not sure what it means.

Copy link
Copy Markdown
Member Author

@fingolfin fingolfin May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it means that this is a debug left-over that should just be removed from matgrp ;-)

Perhaps @hulpke was working on support for $\mathrm{GL}(d,\mathbb{Z}/m\mathbb{Z})$ as input to RecognizeGroup (see also #166), and this was meant to ensure nothing of that sort crept into the wrong places. But this is just speculation.

fi;
return NeverApplicable;
end;
else
Error("<rname> must be the name of a global variable containing a record");
fi;
r.(arg[1]) := CallFuncList(RecogMethod, arg);
name := Concatenation(rname, ".", arg[1]);
SetNameFunction(r.(arg[1])!.func, name);
Expand Down