fix(mutagen): create the remote parent directory before creating the session - #178
Merged
Conversation
…session mutagen creates the synchronization root but not the directories above it. With no ~/Sync on the far side the session came up connected and healthy-looking, and only a transition problem on the beta endpoint revealed that nothing could ever be written.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #177. With the SSH alias in place the session was created for the first time, connected on both ends, and reported
Status: Watching for changes— while being unable to write anything:~/Syncdid not exist on the far side. mutagen creates the synchronization root itself but not the directories above it, and the failure surfaces only insync list --long, not in the status line.One
mkdir -pover SSH beforesync create, non-fatal so an unreachable host still falls through to the existing SKIP path.Verified after creating the directory by hand: a file written on the Mac appeared on the far side, and a file written there appeared locally, both within seconds.