feat(mutagen): retire a pairing once it holds nothing - #183
Merged
Conversation
Pairing on ssh only fixed half of it: every host we ever reached still kept a directory in ~/Sync forever. A pair that is empty on both sides and has been still for an hour is terminated on the next ssh, which cannot lose anything by construction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#182 stopped directories from being recreated on a schedule, but said nothing about the ones already there: a session lives forever once created, so
~/Syncstill accumulated an empty directory per host, which is the clutter the whole rule was meant to avoid.A pairing is now retired on the next ssh when all of these hold:
~/Sync— sessions created by hand elsewhere are not this module's business.Terminating also removes the local directory and the state marker, so the next ssh to that host pairs it again from scratch.
Checked against stub
mutagenwith three sessions in different states: