fix(deps): update module github.com/go-acme/lego/v4 to v5 by gardener-ci-robot · Pull Request #724 · gardener/cert-management

[challenge/dns-persist-01] Update draft-ietf-acme-dns-persist-00 support to 01
[challenge/http-01] Case insensitive match domain
[cli,config] Move revoke command
[cli,log] Format renewal duration
[cli] Add subcommands to the list subcommand
[cli] Certificates sub command
[cli] Move the main package to the root.
[cli] Rename flags tls.port and http.port to tls.address and http.address
[cli] Replace --run-hook and --renew-hook with --deploy-hook
[cli] Require EAB parameters only when needed
[dnsprovider] conoha,conohav3: remove get token from the constructor
[dnsprovider] mijnhost: use single endpoints
[dnsprovider] rfc2136: rename to dnsupdate
[httpprovider] Convert SetProxyHeader to an option
[lib,cli] Change registar method returns
[lib,cli] Use PKCS#8 instead of PKCS#1
[lib] Change CertificateService and GetRenewalInfo signatures
[lib] Disable Common Name by default
[lib] Move enableCommonName option to Request
[lib] Replace crypto.PrivateKey with crypto.Signer
[lib] Use duration as RetryAfter field type
[lib] Use the public key corresponding to the opaque
[log] Improve some log and error messages

Removed

[dnsprovider] Remove deprecated DNS providers: googledomains, azure (replaced by azuredns), cloudxns, dnspod, brandit, iwantmyname, iij (replaced by iijdpf).

Configuration

📅 Schedule: (UTC)

Branch creation
- At any time (no schedule defined)
Automerge
- At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate.

gardener-prow · 2026-05-13T18:52:36Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from martinweindel. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gardener-ci-robot · 2026-05-15T10:55:07Z

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: go.sum

Command failed: go get -t ./...
go: module github.com/go-acme/lego/v4/challenge: reading http://athens-proxy.athens.svc.cluster.local/github.com/go-acme/lego/v4/challenge/@v/list: 500 Internal Server Error
go: module github.com/go-acme/lego/v4/challenge: reading http://athens-proxy.athens.svc.cluster.local/github.com/go-acme/lego/v4/challenge/@v/list: 500 Internal Server Error

gardener-ci-robot · 2026-05-15T14:25:27Z

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

MartinWeindel · 2026-05-15T14:47:31Z

/hold needs more testing

MartinWeindel · 2026-05-19T06:56:04Z

/unhold also tested with precheck namespaces

MartinWeindel · 2026-05-19T06:56:16Z

/cc @marc1404

MartinWeindel · 2026-05-19T13:19:22Z

rebased to resolve merge conflict

MartinWeindel · 2026-05-19T13:31:58Z

/cla

gardener-prow · 2026-05-19T13:32:02Z

Successfully reached out to cla-assistant.io to initialize recheck of PR #724

marc1404

Thank you for taking care of doing all the necessary steps to adapt to the changes in v5 of the library! 🙏
With the help of Claude or not, I appreciate the added test that covers the v4->v5 migration path: 17c7515 (this PR)

A few comments below 👇

marc1404 · 2026-05-22T07:14:16Z

+// parseNameservers ensures that all nameservers have a port number, and adds the default DNS port 53 if not.
+// This function replicates functionality that was removed from lego v5.
+func parseNameservers(servers []string) []string {
+	var resolvers []string
+	for _, resolver := range servers {
+		// ensure all servers have a port number
+		if _, _, err := net.SplitHostPort(resolver); err != nil {
+			resolvers = append(resolvers, net.JoinHostPort(resolver, "53"))
+		} else {
+			resolvers = append(resolvers, resolver)
+		}
+	}
+	return resolvers
+}


This function could be covered by unit tests

This is indirectly already covered by unit tests for the PreparePrecheckNameservers method.
A few more test cases have been added for IPv6.

… server

…r ACME registration (with help of claude)

MartinWeindel · 2026-05-22T14:45:30Z

rebased to resolve merge conflict

gardener-ci-robot added the kind/enhancement Enhancement, improvement, extension label May 12, 2026

gardener-prow Bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 12, 2026

gardener-ci-robot force-pushed the renovate/github.com-go-acme-lego-v4-5.x branch 5 times, most recently from 55d462d to bdb76bb Compare May 13, 2026 12:55

MartinWeindel self-assigned this May 13, 2026

gardener-ci-robot force-pushed the renovate/github.com-go-acme-lego-v4-5.x branch from bdb76bb to 5a23fdf Compare May 13, 2026 18:52

gardener-ci-robot force-pushed the renovate/github.com-go-acme-lego-v4-5.x branch 3 times, most recently from f552350 to 272166b Compare May 15, 2026 10:55

gardener-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 15, 2026

MartinWeindel force-pushed the renovate/github.com-go-acme-lego-v4-5.x branch from 95d7494 to 7f78a09 Compare May 15, 2026 14:46

gardener-prow Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 15, 2026

gardener-prow Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2026

gardener-prow Bot requested a review from marc1404 May 19, 2026 06:56

MartinWeindel force-pushed the renovate/github.com-go-acme-lego-v4-5.x branch from 2b00c93 to adb9583 Compare May 19, 2026 13:19

gardener-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2026

marc1404 reviewed May 22, 2026

View reviewed changes

MartinWeindel added 7 commits May 22, 2026 16:39

migrate code from acme-lego v4 to v5

3450acd

Deal with issuer status from lego <= v4: fetch account info from ACME…

a3c9825

… server

added comprehensive unit tests for the v4 to v5 migration scenario fo…

c73999d

…r ACME registration (with help of claude)

Refactor ACME registration API with v4-to-v5 migration control flag

f5cc6e9

fix integration tests

cfd2aa9

make generate: fix formatting

e7cac39

fix golangci-lint issues; minor refactoring

f487443

MartinWeindel force-pushed the renovate/github.com-go-acme-lego-v4-5.x branch from adb9583 to 83bd76d Compare May 22, 2026 14:39

gardener-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2026

address review feedback

250f380

MartinWeindel force-pushed the renovate/github.com-go-acme-lego-v4-5.x branch from 83bd76d to 250f380 Compare May 22, 2026 14:43

Conversation

gardener-ci-robot commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release Notes

v5.0.4

Fixed

v5.0.3

Fixed

Added

v5.0.2

Fixed

v5.0.1

Fixed

v5.0.0

Added

Changed

Removed

Configuration

Uh oh!

gardener-prow Bot commented May 13, 2026

Uh oh!

gardener-ci-robot commented May 15, 2026

⚠️ Artifact update problem

File name: go.sum

Uh oh!

gardener-ci-robot commented May 15, 2026

Edited/Blocked Notification

Uh oh!

MartinWeindel commented May 15, 2026

Uh oh!

MartinWeindel commented May 19, 2026

Uh oh!

MartinWeindel commented May 19, 2026

Uh oh!

MartinWeindel commented May 19, 2026

Uh oh!

MartinWeindel commented May 19, 2026

Uh oh!

gardener-prow Bot commented May 19, 2026

Uh oh!

marc1404 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

marc1404 May 22, 2026

Choose a reason for hiding this comment

Uh oh!

MartinWeindel May 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MartinWeindel commented May 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gardener-ci-robot commented May 12, 2026 •

edited

Loading

`v5.0.4`

`v5.0.3`

`v5.0.2`

`v5.0.1`

`v5.0.0`