Extend the defaults accepted via configuration#2476
Conversation
|
Thank you @benedikt-haug for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
|
@benedikt-haug Thank you for your contribution. |
|
/ok-to-test |
|
Nice! |
|
Maybe it would be better to group the default options under a key in the config, e.g., Additionally, these values need to be added to the Helm charts. Right now, the Helm charts are the only documentation for the dashboard configuration. We should consider introducing a dedicated documentation page for the configuration — but that’s a separate task and not related to this PR. |
Sure <3
Seems reasonable :) Incorporated that feedback. Also moved the "old" variables there, while including a fallback for the users of the old naming scheme so things don't suddenly break.
Added an example like the other repos have it. Also tried to extend the helm charts to feature the new variable. Do you know how to test the charts locally, |
We implemented tests for the help charts. You can adapt them and run them with |
|
@holgerkoser, @klocke-io You have pull request review open invite, please check |
though my linter is persistent about using shootDefaults.value instead
92e832a to
07d8038
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe change consolidates frontend shoot defaults under ChangesShoot defaults and configuration
Estimated code review effort: 4 (Complex) | ~60 minutes Suggested labels: Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant FrontendConfig
participant useConfigStore
participant gardenerExtensionStore
participant useShootContext
FrontendConfig->>useConfigStore: load shootDefaults
useConfigStore->>gardenerExtensionStore: provide defaultNetworkingType
useConfigStore->>useShootContext: provide configured defaults
gardenerExtensionStore->>useShootContext: provide sortedNetworkingTypes
useShootContext->>useShootContext: createShootManifest
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/src/utils/index.js`:
- Around line 521-525: Update randomMaintenanceBegin to handle an explicitly
empty hours array before calling sample, returning the established safe
maintenance-window fallback instead of interpolating undefined. Preserve the
current random selection and formatting behavior when hours contains values.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 16e32087-8a69-494b-8cbe-90ee6484be5c
⛔ Files ignored due to path filters (1)
charts/__tests__/gardener-dashboard/runtime/dashboard/__snapshots__/configmap.spec.js.snapis excluded by!**/*.snap
📒 Files selected for processing (17)
backend/__tests__/routes.config.spec.jsbackend/lib/routes/config.jscharts/__tests__/gardener-dashboard/runtime/dashboard/configmap.spec.jscharts/gardener-dashboard/charts/runtime/templates/dashboard/configmap.yamlcharts/gardener-dashboard/values.yamldocs/development/local-setup.mdexample/00-configmap-gardener-dashboard-frontend.yamlfrontend/__tests__/components/GWildcardSelect.spec.jsfrontend/__tests__/composables/useShootContext.spec.jsfrontend/__tests__/stores/config.spec.jsfrontend/src/components/GWildcardSelect.vuefrontend/src/components/NewShoot/GNewShootInfrastructureDetails.vuefrontend/src/composables/useShootContext.jsfrontend/src/composables/useShootHelper.jsfrontend/src/store/config.jsfrontend/src/store/gardenerExtension.jsfrontend/src/utils/index.js
What this PR does / why we need it:
This PR is part of the Hackaton.
This PR extend the defaults gardener dashboard accepts via configuration.
Additionally, it moves the default declaration to the config store so they are declared in the same spot.
Lastly, it also adds the example folder describing the new additions made possible by the gardener-dashboard-frontend configmap.
Which issue(s) this PR fixes:
Special notes for your reviewer:
/cc @marc1404 @klocke-io
Release note:
Summary by CodeRabbit
shootDefaultssupport for hibernation/maintenance, autoscaling, workerless defaults, container runtime, purposes, networking, and help text, while keeping legacy compatibility.shootDefaultsand validatecontrolPlaneHighAvailabilityHelp.text.shootDefaultsstructure.