Move credential details to vendor configuration#3085
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (37)
📝 WalkthroughWalkthroughCredential secret details are now declared in infrastructure and DNS vendor configurations. Shared resolution supports alternate keys, Base64 decoding, JSON parsing, nested paths, and hidden fields. Credential composables and components pass vendor-specific configurations into the resolver, with expanded tests. ChangesVendor-configured secret details
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant CredentialView
participant CredentialComposable
participant ConfigStore
participant SecretDetails
CredentialView->>CredentialComposable: resolve credential details
CredentialComposable->>ConfigStore: vendorDetails({ type, name })
ConfigStore-->>CredentialComposable: return providerConfig
CredentialComposable->>SecretDetails: resolve secret with providerConfig
SecretDetails-->>CredentialView: return labeled values
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What this PR does / why we need it:
This is the third preparatory refactor extracted from #2824 and follows the vendor registry extraction in #3075 and typed vendor lookups in #3082.
Credential detail rendering previously used a provider-name switch in
credential/helper.js. That kept provider-specific display metadata in application code and required extending the switch for every supported vendor.This change:
frontend/src/data/vendorsinfraordnsdomainuseDnsProviderCredentialRelated PRs:
Which issue(s) this PR fixes:
None.
Special notes for your reviewer:
Please review this as the third preparatory refactor in the sequential split of #2824. The
secret.detailsconfiguration is read-only display metadata; it is not used when creating or updating Secrets.Validation:
make verifyRelease note:
Summary by CodeRabbit
New Features
Bug Fixes
Tests