Skip to content

enh(frontend): use light background for infra icons#3090

Open
julestree wants to merge 1 commit into
masterfrom
chore/frontend-vendor-icon-background
Open

enh(frontend): use light background for infra icons#3090
julestree wants to merge 1 commit into
masterfrom
chore/frontend-vendor-icon-background

Conversation

@julestree

@julestree julestree commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

How to categorize this PR?

/area usability
/kind enhancement

What this PR does / why we need it:
Adds a light background color to the infra icons so that they are easily visible in dark mode.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

Screenshots:

Before:

Screenshot 2026-07-20 at 16 10 40

After:

Screenshot 2026-07-20 at 16 12 49

Summary by CodeRabbit

  • Style
    • Improved dark-mode vendor icon visibility by applying a consistent light background color.

@julestree
julestree requested a review from a team as a code owner July 20, 2026 14:14
@gardener-prow gardener-prow Bot added area/usability Usability related kind/enhancement Enhancement, improvement, extension labels Jul 20, 2026
@gardener-prow

gardener-prow Bot commented Jul 20, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign klocke-io for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Jul 20, 2026
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 79859730-c4ed-40a0-a8ec-b310bbf2c4d1

📥 Commits

Reviewing files that changed from the base of the PR and between e467be2 and 4e02e3b.

📒 Files selected for processing (1)
  • frontend/src/components/GVendorIcon.vue

📝 Walkthrough

Walkthrough

The vendor icon component’s dark-theme background now uses the fixed color #e0e0e0, replacing the Vuetify grey palette lookup and removing the associated Sass imports.

Changes

Vendor icon theme styling

Layer / File(s) Summary
Dark-theme background color
frontend/src/components/GVendorIcon.vue
The dark-theme .icon-background style uses #e0e0e0 instead of a Vuetify palette lookup, and unused Sass imports are removed.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: grolu

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the change by describing the new lighter background for infra icons.
Description check ✅ Passed The description mostly follows the template with categorization, purpose, and release note filled in; only the issue reference is incomplete.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/frontend-vendor-icon-background

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/usability Usability related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant