Skip to content

Feature: Map flavor not found to ResourceExhausted grpc code#383

Merged
gardener-prow[bot] merged 4 commits into
gardener:masterfrom
viragvoros:flavor-not-found-mapping
May 12, 2026
Merged

Feature: Map flavor not found to ResourceExhausted grpc code#383
gardener-prow[bot] merged 4 commits into
gardener:masterfrom
viragvoros:flavor-not-found-mapping

Conversation

@viragvoros
Copy link
Copy Markdown
Contributor

@viragvoros viragvoros commented May 7, 2026 •
edited by takoverflow
Loading

How to categorize this PR?
/area robustness
/kind enhancement
/platform openstack

What this PR does / why we need it:
This PR improves OpenStack machine error handling by classifying flavor resolution failures and mapping them to codes.ResourceExhausted. Previously, only NoValidHost errors were classified as resource exhausted errors.

Special notes for your reviewer:
None

Release note:

Improved OpenStack machine error handling by classifying flavor resolution failure as resource exhaustion.

@viragvoros viragvoros requested review from a team as code owners May 7, 2026 14:40
@gardener-prow gardener-prow Bot added area/robustness Robustness, reliability, resilience related kind/enhancement Enhancement, improvement, extension labels May 7, 2026
@gardener-prow
Copy link
Copy Markdown

gardener-prow Bot commented May 7, 2026

Welcome @viragvoros!

It looks like this is your first PR to gardener/machine-controller-manager-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if gardener/machine-controller-manager-provider-openstack has its own contribution guidelines.

Thank you, and welcome to Gardener. 😃

@gardener-prow gardener-prow Bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 7, 2026
@federated-github-access
Copy link
Copy Markdown
Contributor

federated-github-access Bot commented May 7, 2026

The PR needs to be labeled with ok-to-test by a maintainer to trigger the automated validation of the change

1 similar comment
@federated-github-access
Copy link
Copy Markdown
Contributor

federated-github-access Bot commented May 7, 2026

The PR needs to be labeled with ok-to-test by a maintainer to trigger the automated validation of the change

@takoverflow takoverflow added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 7, 2026
@federated-github-access federated-github-access Bot removed the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 7, 2026
@federated-github-access
Copy link
Copy Markdown
Contributor

federated-github-access Bot commented May 7, 2026

The PR needs to be labeled with ok-to-test by a maintainer to trigger the automated validation of the change

1 similar comment
@federated-github-access
Copy link
Copy Markdown
Contributor

federated-github-access Bot commented May 7, 2026

The PR needs to be labeled with ok-to-test by a maintainer to trigger the automated validation of the change

aaronfern
aaronfern reviewed May 11, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@aaronfern aaronfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @viragvoros!
A couple comments, ptal

Comment thread pkg/driver/executor/errors.go
Comment thread pkg/driver/utils.go
@gardener-prow gardener-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 11, 2026
@federated-github-access
Copy link
Copy Markdown
Contributor

federated-github-access Bot commented May 11, 2026

The PR needs to be labeled with ok-to-test by a maintainer to trigger the automated validation of the change

@viragvoros
Copy link
Copy Markdown
Contributor Author

viragvoros commented May 11, 2026 •
edited
Loading

Hi @aaronfern, thank you for the review :)

I added the suggestions, let me know if there is anything else to improve.

takoverflow
takoverflow reviewed May 11, 2026
View reviewed changes
Comment thread pkg/driver/executor/errors.go Outdated
@federated-github-access
Copy link
Copy Markdown
Contributor

federated-github-access Bot commented May 12, 2026

The PR needs to be labeled with ok-to-test by a maintainer to trigger the automated validation of the change

@aaronfern aaronfern added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 12, 2026
@federated-github-access
Copy link
Copy Markdown
Contributor

federated-github-access Bot commented May 12, 2026

The PR needs to be labeled with ok-to-test by a maintainer to trigger the automated validation of the change

aaronfern
aaronfern reviewed May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@aaronfern aaronfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple more nits

Comment thread pkg/driver/utils_test.go Outdated
Comment thread pkg/driver/executor/errors.go Outdated
@federated-github-access
Copy link
Copy Markdown
Contributor

federated-github-access Bot commented May 12, 2026

The PR needs to be labeled with ok-to-test by a maintainer to trigger the automated validation of the change

@aaronfern
Copy link
Copy Markdown
Member

aaronfern commented May 12, 2026

Thank you for the changes!
/lgtm
/ok-to-test

@gardener-prow gardener-prow Bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 12, 2026
@gardener-prow gardener-prow Bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2026
@gardener-prow
Copy link
Copy Markdown

gardener-prow Bot commented May 12, 2026

LGTM label has been added.

DetailsGit tree hash: 6db53c71411677b27dcfa2ea7515fcc3d95250ea

@federated-github-access federated-github-access Bot removed the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 12, 2026
@aaronfern
Copy link
Copy Markdown
Member

aaronfern commented May 12, 2026

/approve

@gardener-prow gardener-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2026
@gardener-prow
Copy link
Copy Markdown

gardener-prow Bot commented May 12, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aaronfern

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow Bot merged commit 015e503 into gardener:master May 12, 2026
27 checks passed
@federated-github-access federated-github-access Bot mentioned this pull request May 20, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@takoverflow takoverflow takoverflow left review comments

@aaronfern aaronfern aaronfern approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/robustness Robustness, reliability, resilience related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@viragvoros @aaronfern @takoverflow