Open
Conversation
andrian2929
reviewed
Oct 12, 2024
| */ | ||
| public function registrationCompleted(string $verifiedToken, string $userUuid, string $firstName, string $lastName, string $gender) | ||
| { | ||
| $data = $this->mainRepository->registrationCompleted($verifiedToken, $userUuid, $firstName, $lastName, $gender); |
There was a problem hiding this comment.
userUuid nya gak mau dikasih validasi kah? karena di postgresql, kalau gak valid uuid nya akan throw query error
| public function registrationCompleted($verifiedToken, $userUuid, RegistrationCompletedRequest $request) | ||
| { | ||
| // dd([$verifiedToken, $userUuid]); | ||
| $data = $this->authService->registrationCompleted($verifiedToken, $userUuid, $request->validated('firstName'), $request->validated('lastName'), $request->validated('gender')); |
There was a problem hiding this comment.
untuk token ini ada masa berlakunya nya gak jar?
Member
Author
There was a problem hiding this comment.
gaada, bagusnya gimana?
There was a problem hiding this comment.
bagus kasih aja sih, ntah berapa lama jangan permanen, tapi gak urgent juga
| 'gender', | ||
| 'email', | ||
| 'password', | ||
| 'photo_path', |
There was a problem hiding this comment.
gak mau tambah email_verified_at, biar tau kapan akunnya pertama kali terverifikasi?
| return [ | ||
| 'firstName' => ['required', 'string', 'max:255'], | ||
| 'lastName' => ['required', 'string', 'max:255'], | ||
| 'gender' => ['required', 'string', 'in:male,female'], |
There was a problem hiding this comment.
yang gender ini kan enum, bisa diganti jadi Rule::enum(GenderType::class)],
use App\Enum\GenderType;
use Illuminate\Validation\Rule;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.