fix: correct codex CLI invocation flags#426
Open
datashaman wants to merge 3 commits intogarrytan:mainfrom
Open
fix: correct codex CLI invocation flags#426datashaman wants to merge 3 commits intogarrytan:mainfrom
datashaman wants to merge 3 commits intogarrytan:mainfrom
Conversation
- model_reasoning_effort="xhigh" → "high" (valid: minimal/low/medium/high) - --enable web_search_cached → --search (old flag removed) - Update test assertions to match new flag values These flags caused codex invocations to fail on first try, requiring multiple retries before Claude found the correct combination. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
codex review doesn't support --json or --search flags. codex exec review supports --json for JSONL output parsing. Also update web search docs to clarify which modes support --search. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
datashaman
force-pushed
the
fix/codex-invocation-flags
branch
from
55a9388 to
baac156
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I've watched Claude stumble over this so, so many times, I thought I should propose a change instead.
Not sure what the policy is for supporting versions of independent commands, this is for the current one (0.116.0).
Changes
model_reasoning_effort="xhigh"→"high"—xhighis not a valid value (API rejects it withunsupported_value). Valid values:low,medium,high.--enable web_search_cached→--search—web_search_cachedis a deprecated feature flag. The--searchflag is the correct replacement.codex review --base→codex exec review --base --json—codex reviewdoesn't support--jsonor--searchflags.codex exec reviewdoes, and is needed for structured JSONL output parsing.[P0]or[P1]markers (was[P1]only) — matches the actual priority tags from codex's built-inreview_prompt.md: P0 (drop everything), P1 (urgent), P2 (normal), P3 (nice-to-have).Verified against codex-cli 0.116.0.
Test plan
bun test test/skill-validation.test.ts test/gen-skill-docs.test.ts— 556 pass, 1 pre-existing fail (version mismatch)bun run gen:skill-docsregenerates all SKILL.md files cleanlycodex exec review --base main --jsonproduces valid JSONL outputmodel_reasoning_effort="high"is accepted by the APImodel_reasoning_effort="xhigh"is rejected by the API🤖 Generated with Claude Code